fix(ASUS Ally): don't crash out of driver init if attrs fail#341
Merged
ShadowApex merged 1 commit intoShadowBlip:mainfrom Apr 23, 2025
Merged
fix(ASUS Ally): don't crash out of driver init if attrs fail#341ShadowApex merged 1 commit intoShadowBlip:mainfrom
ShadowApex merged 1 commit intoShadowBlip:mainfrom
Conversation
Contributor
Author
|
Also requires driver update. This is in progress and mostly complete now. |
flukejones
force-pushed
the
fluke/asus_ally
branch
2 times, most recently
from
4c874b1 to
bee1fd4
Compare
flukejones
force-pushed
the
fluke/asus_ally
branch
from
bee1fd4 to
2f65ab7
Compare
Contributor
Author
|
This should be working with both old and new driver versions now. Although I'm not sure how to test |
Contributor
Author
|
Note: revised driver doesn't have backface button mapping complete (yet). Should be done in a day. |
flukejones
force-pushed
the
fluke/asus_ally
branch
from
2f65ab7 to
f5c8fbf
Compare
Contributor
Author
|
Currently having issues with the IP config not grabbing the mouse and keyboard event devices as it should: when using the driver revision from https://github.com/flukejones/linux/tree/wip/ally-6.14-refactor The IP driver does set QAM mode off, and does remap fine. You will notice: which can be ignored. |
Contributor
Author
|
Log: |
Instead of bombing out of the driver init process allow IP to keep working as the majority of parts should still be usable. Signed-off-by: Luke Jones <luke@ljones.dev>
flukejones
force-pushed
the
fluke/asus_ally
branch
from
f5c8fbf to
b03624b
Compare
Contributor
Author
|
Wrong PID in the Ally X config. Thanks @pastaq. Tested, all working with updated driver and old driver. |
ShadowApex
approved these changes
Apr 23, 2025
Contributor
ShadowApex
left a comment
ShadowApex
left a comment
There was a problem hiding this comment.
Looks good! Thanks for these changes!
Contributor
|
🎉 This PR is included in version 0.54.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of bombing out of the driver init process allow IP to keep working as the majority of parts should still be usable.