fix: address critical security vulnerabilities and documentation inaccuracies#1
Merged
ShaneIsley merged 1 commit intomainfrom Jan 29, 2026
Merged
Conversation
…curacies
Security fixes:
- Fix insecure Unix socket permissions (0666 → 0600) in daemon.go
Prevents unauthorized users from accessing the daemon socket
- Remove CURL_CA_BUNDLE="" that disabled TLS certificate validation
This was silently making all curl operations vulnerable to MITM attacks
Documentation fixes:
- Change "Zero dependencies" to "Minimal dependencies" (README.md:22)
The claim was false - project uses Cobra, Viper, SQLite, etc.
- Change "11 backoff strategies" to "10 backoff strategies" (README.md:17)
Only 10 strategies are actually implemented
Code quality improvements:
- Improve HTTP JSON parsing with proper brace matching instead of
naive first-{ to last-} heuristics that could match unrelated content
- Add findMatchingBrace() helper that handles strings and escaping
- Limit JSON search to 10KB to avoid processing huge outputs
- Add architectural note about daemon.go duplicating UnixServer logic
https://claude.ai/code/session_01NSTdboMz5UFPifG8cDfVr1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security fixes:
Prevents unauthorized users from accessing the daemon socket
This was silently making all curl operations vulnerable to MITM attacks
Documentation fixes:
The claim was false - project uses Cobra, Viper, SQLite, etc.
Only 10 strategies are actually implemented
Code quality improvements:
naive first-{ to last-} heuristics that could match unrelated content
https://claude.ai/code/session_01NSTdboMz5UFPifG8cDfVr1