Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed null deprecation in Zend/Pdf/Resource/Font/Simple #459

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

kiatng
Copy link

@kiatng kiatng commented Nov 15, 2024

I tried to fix the iconv() null deprecation on parameter #3 in the sources that use the PDF lib, but that proved to be very difficult to pin. Even numerous fixes in drawText() (maybe it's not from it) the errors keep popping up.

@develart-projects
Copy link
Collaborator

I think we can replace

if ($string === null || $string === '') { return 0; }

with

if ( empty($string) ) { return 0; }

..to make things more readable :)

@develart-projects develart-projects added this to the 1.24.3 milestone Nov 15, 2024
@develart-projects develart-projects added the bug Something isn't working label Nov 15, 2024
@sreichel
Copy link

I think we can replace

No. Empty is bad.

$string = '0';
var_dump(($string === null || $string === '') === (empty($string)));

@develart-projects
Copy link
Collaborator

OK, got the point, thanks.

@develart-projects develart-projects merged commit 66c65b8 into Shardj:master Nov 15, 2024
11 checks passed
@develart-projects develart-projects added the to be released PR exists or in master, but not released yet label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working to be released PR exists or in master, but not released yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants