Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YT] Fix "Could not get like count" #30

Merged
merged 1 commit into from
Dec 10, 2023
Merged

[YT] Fix "Could not get like count" #30

merged 1 commit into from
Dec 10, 2023

Conversation

ShareASmile
Copy link
Owner

@ShareASmile ShareASmile commented Dec 10, 2023

  1. YT uses a different data structure for likes (ViewModels instead of Renderers)
  2. Fixed NPE in old code due to incorrect usage of string comparison
  3. Unified JSONObject filtering and mapping
  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

1. YT uses a different data structure for likes (ViewModels instead of Renderers)
2. Fixed NPE in old code due to incorrect usage of string comparison
3. Unified JSONObject filtering and mapping

Co-Authored-By: litetex <40789489+litetex@users.noreply.github.com>
@ShareASmile ShareASmile merged commit 756ac53 into ify Dec 10, 2023
1 check failed
@ShareASmile ShareASmile deleted the fix-yt-like-count branch December 10, 2023 11:42
Repository owner locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant