Skip to content

Workflow doc updates for the change in app-only handling #10001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

jansenbe
Copy link
Contributor

@jansenbe jansenbe commented Nov 6, 2024

Prep for upcoming changes in the SharePoint Workflow platform.

Copy link
Contributor

Learn Build status updates of commit de0aba1:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/general-development/create-a-workflow-with-elevated-permissions-by-using-the-sharepoint-workflo.md ⚠️Warning View Details
docs/general-development/workflow-with-elevated-permissions-new-guidance.md ⚠️Warning View Details
docs/images/workflowappinvstepnew.png ✅Succeeded View

docs/general-development/create-a-workflow-with-elevated-permissions-by-using-the-sharepoint-workflo.md

  • Line 9, Column 1: [Warning: duplicate-h1s - See documentation] H1 'Create a workflow with elevated permissions by using the SharePoint Workflow platform' is duplicated with other articles: 'general-development/create-a-workflow-with-elevated-permissions-by-using-the-sharepoint-workflo.md(9,1), general-development/workflow-with-elevated-permissions-new-guidance.md(9,1)'. First level headings must be unique within a docset.
  • Line 183, Column 173: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/graph/api/directory-deleteditems-restore?tabs=http' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'Create SharePoint workflows that access objects in SharePoint that require elevated permissions. These solutions grant permissions to the workflow app and wrap actions with the App Step.' is duplicated in 'general-development/create-a-workflow-with-elevated-permissions-by-using-the-sharepoint-workflo.md(3,14)', 'general-development/workflow-with-elevated-permissions-new-guidance.md(3,14)'.
  • Line 183, Column 173: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/graph/api/directory-deleteditems-restore?tabs=http' will be broken in isolated environments. Replace with a relative link.

docs/general-development/workflow-with-elevated-permissions-new-guidance.md

  • Line 9, Column 1: [Warning: duplicate-h1s - See documentation] H1 'Create a workflow with elevated permissions by using the SharePoint Workflow platform' is duplicated with other articles: 'general-development/create-a-workflow-with-elevated-permissions-by-using-the-sharepoint-workflo.md(9,1), general-development/workflow-with-elevated-permissions-new-guidance.md(9,1)'. First level headings must be unique within a docset.
  • Line 157, Column 173: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/graph/api/directory-deleteditems-restore?tabs=http' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'Create SharePoint workflows that access objects in SharePoint that require elevated permissions. These solutions grant permissions to the workflow app and wrap actions with the App Step.' is duplicated in 'general-development/create-a-workflow-with-elevated-permissions-by-using-the-sharepoint-workflo.md(3,14)', 'general-development/workflow-with-elevated-permissions-new-guidance.md(3,14)'.
  • Line 157, Column 173: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/graph/api/directory-deleteditems-restore?tabs=http' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit cdaea03:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/general-development/create-a-workflow-with-elevated-permissions-by-using-the-sharepoint-workflo.md ⚠️Warning View Details
docs/general-development/workflow-with-elevated-permissions-new-guidance.md ⚠️Warning View Details
docs/images/workflowappinvstepnew.png ✅Succeeded View

docs/general-development/create-a-workflow-with-elevated-permissions-by-using-the-sharepoint-workflo.md

  • Line 9, Column 1: [Warning: duplicate-h1s - See documentation] H1 'Create a workflow with elevated permissions by using the SharePoint Workflow platform' is duplicated with other articles: 'general-development/create-a-workflow-with-elevated-permissions-by-using-the-sharepoint-workflo.md(9,1), general-development/workflow-with-elevated-permissions-new-guidance.md(9,1)'. First level headings must be unique within a docset.
  • Line 183, Column 173: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/graph/api/directory-deleteditems-restore?tabs=http' will be broken in isolated environments. Replace with a relative link.

docs/general-development/workflow-with-elevated-permissions-new-guidance.md

  • Line 9, Column 1: [Warning: duplicate-h1s - See documentation] H1 'Create a workflow with elevated permissions by using the SharePoint Workflow platform' is duplicated with other articles: 'general-development/create-a-workflow-with-elevated-permissions-by-using-the-sharepoint-workflo.md(9,1), general-development/workflow-with-elevated-permissions-new-guidance.md(9,1)'. First level headings must be unique within a docset.
  • Line 157, Column 173: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/graph/api/directory-deleteditems-restore?tabs=http' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@andrewconnell andrewconnell added the pr:in-review Actively reviewing pull request label Nov 16, 2024
@andrewconnell andrewconnell self-assigned this Nov 16, 2024
@andrewconnell
Copy link
Collaborator

@jansenbe It appears the two MD files in this PR are dupes of each other... one is an edit of an existing one, the other is new... or am I missing something?

It's better to have a single source of truth rather than dupes.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@andrewconnell
Copy link
Collaborator

@jansenbe I made some copy edits to the existing page as I suspect the new page that starts with "workflow-" is an accidental dupe per my last comment.

Copy link
Contributor

Learn Build status updates of commit ad84490:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/general-development/create-a-workflow-with-elevated-permissions-by-using-the-sharepoint-workflo.md ⚠️Warning View Details
docs/general-development/workflow-with-elevated-permissions-new-guidance.md ⚠️Warning View Details
docs/images/workflowappinvstepnew.png ✅Succeeded View

docs/general-development/create-a-workflow-with-elevated-permissions-by-using-the-sharepoint-workflo.md

  • Line 9, Column 1: [Warning: duplicate-h1s - See documentation] H1 'Create a workflow with elevated permissions by using the SharePoint Workflow platform' is duplicated with other articles: 'general-development/create-a-workflow-with-elevated-permissions-by-using-the-sharepoint-workflo.md(9,1), general-development/workflow-with-elevated-permissions-new-guidance.md(9,1)'. First level headings must be unique within a docset.

docs/general-development/workflow-with-elevated-permissions-new-guidance.md

  • Line 9, Column 1: [Warning: duplicate-h1s - See documentation] H1 'Create a workflow with elevated permissions by using the SharePoint Workflow platform' is duplicated with other articles: 'general-development/create-a-workflow-with-elevated-permissions-by-using-the-sharepoint-workflo.md(9,1), general-development/workflow-with-elevated-permissions-new-guidance.md(9,1)'. First level headings must be unique within a docset.
  • Line 157, Column 173: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/graph/api/directory-deleteditems-restore?tabs=http' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Collaborator

@andrewconnell andrewconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears the new file is a file renamed dupe of an existing page. if that's correct, then we need to either:

  1. delete the old file, create redirects in the ./.openpublishing.redirection.json file, and update any internal links to point to the newly named file OR
  2. delete the new file

We shouldn't have the same content duped on 2 pages (bad SEO)

@andrewconnell andrewconnell added Needs: Author Feedback Awaiting response from the original poster of the issue. Marked as stale if no activity for 7 days. pr:do-not-merge Pull request not ready to be merged and removed pr:in-review Actively reviewing pull request labels Nov 16, 2024
@andrewconnell andrewconnell added the no-recent-activity Stale issue due to lack of activity. Closed after 7 days with no activity by OP. label Feb 4, 2025
@andrewconnell
Copy link
Collaborator

@jansenbe bump ;)

@jansenbe jansenbe closed this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Author Feedback Awaiting response from the original poster of the issue. Marked as stale if no activity for 7 days. no-recent-activity Stale issue due to lack of activity. Closed after 7 days with no activity by OP. pr:do-not-merge Pull request not ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants