multilang-support Dockerfile (upgrade PyTorch, CUDA), cleanup, warmup endpoint#1093
Merged
multilang-support Dockerfile (upgrade PyTorch, CUDA), cleanup, warmup endpoint#1093
Conversation
… consolidation), specifying versions in requirements.txt, utils.py logic
jeffbl
requested changes
Jun 19, 2025
Member
jeffbl
left a comment
There was a problem hiding this comment.
Need to limit the number of model downloads, other comments just tweaks.
jeffbl
approved these changes
Jun 19, 2025
Member
jeffbl
left a comment
There was a problem hiding this comment.
Still surprised python3 needs to be installed, but no harm, should be a noop if not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a few issues, #1091 + beyond.
issue with multilang isnt just the torch v..
25-06-19 19:12 UTC [WARNING]: Cannot find /app/models/opus-mt-en-fr, is it pre-downloaded?
25-06-19 19:12 UTC [INFO]: Downloading model from HuggingFace model hub...
25-06-19 19:12 UTC [ERROR]: Could not find MarianMTModel neither in <module 'transformers.models.marian' from '/opt/conda/lib/python3.10/site-packages/transformers/models/marian/init.py'> nor in <module 'transformers' from '/opt/conda/lib/python3.10/site-packages/transformers/init.py'>
the Hugging Face transformers lib was attempting to import MarianMTModel, which triggers loading modules from torchvision, but the version of torchvision bundled in pytorch/pytorch:latest (which is the base image we’re using) is incompatible with the latest transformers.
Please ensure you've followed the checklist and provide all the required information before requesting a review.
If you do not have everything applicable to your PR, it will not be reviewed!
If you don't know what something is or if it applies to you, ask!
Don't delete below this line.
Required Information
Coding/Commit Requirements
New Component Checklist (mandatory for new microservices)
docker-compose.ymlandbuild.yml..github/workflows.README.mdfile that describes what the component does and what it depends on (other microservices, ML models, etc.).OR