DO NOT MERGE: Image text overlay #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azharbeebeejaun
suggested changes
Aug 21, 2017
| @@ -0,0 +1,23 @@ | |||
| public class ImageTextOverlay { | |||
| private sharinpix.Utils utils; | |||
| public ImageTextOverlay(){ | |||
| } | ||
| public String overlayText(String imageId, String text, String fontStyle, String fontSize, String fontEmphasis, String gravity, String borderWidth, String borderStyle, String borderColor){ | ||
| String sanitizedText = EncodingUtil.urlEncode(text, 'UTF-8').replaceAll('\\+', '%20').replaceAll('%2C', '%252C'); | ||
| String overlay = 'text:'+fontStyle+'_'+fontSize+'_'+fontEmphasis+'_stroke:'+sanitizedText+',bo_'+borderWidth+'px_'+borderStyle+'_'+borderColor; |
Contributor
There was a problem hiding this comment.
no need to align = and =>... will have problems when adding more assignment statements
| 'Id' => albumId | ||
| }); | ||
| } | ||
| /** |
| @RemoteAction | ||
| global static String overlayText(String imageId, String text, String options){ | ||
| map<string, object> optionsMap = (map<string, object>) JSON.deserializeUntyped(options); | ||
| String fontStyle = (String) optionsMap.get('fontStyle'); |
| * @param options [JSON string with more image transformation options] | ||
| * @return [image URL of image with overlaid text] | ||
| */ | ||
| @RemoteAction |
| @@ -0,0 +1,5 @@ | |||
|
|
|||
Contributor
There was a problem hiding this comment.
no beginning space in xml
src/pages/ImageTextOverlayPage.page
Outdated
| var fontSize = document.getElementById("fontSizeInput").value; | ||
| var fontEmphasis = document.getElementById("fontEmphasisInput").value; | ||
| var gravity = document.getElementById("gravityInput").value; | ||
| var borderWidth = document.getElementById("borderWidthInput").value; |
Contributor
There was a problem hiding this comment.
indentation - using tabs
| } | ||
| } | ||
| ); | ||
| }//end cropFace |
| global class ImageTextOverlayController { | ||
| global String parameters {set;get;} | ||
| public Id albumId; | ||
| public ImageTextOverlayController(ApexPages.standardController controller){ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.