DO NOT MERGE: Upload using URL #6
Conversation
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <ApexClass xmlns="http://soap.sforce.com/2006/04/metadata"> | ||
| <apiVersion>40.0</apiVersion> | ||
| <packageVersions> |
There was a problem hiding this comment.
remove packageVersions tag from meta.xmls
| <script>document.write(generateUrlInput(0))</script> | ||
| </div> | ||
| <div class="margined-top slds-form-element"> | ||
| <button type="button" onclick="uploadAll()" class="margined-top slds-button slds-button_brand"> |
There was a problem hiding this comment.
try using slds padding/margin classes https://www.lightningdesignsystem.com/utilities/padding/
| <minorNumber>7</minorNumber> | ||
| <namespace>sf_com_apps</namespace> | ||
| </packageVersions> | ||
| <packageVersions> |
There was a problem hiding this comment.
remove meta package (sharinpix + tfa)
| public static Boolean uploadByUrls(String albumId, String url, String filename) { | ||
| sharinpix.Utils utils = new sharinpix.Utils(); | ||
| utils.uploadFromUrl(url, albumId, filename); | ||
| return true; |
There was a problem hiding this comment.
return true always ?
There was a problem hiding this comment.
add status messages or return void
| '" class="slds-input" placeholder="Filename" /></div></div><div class="slds-p-horizontal_small'+ | ||
| ' slds-size_1-of-1 slds-medium-size_1-of-1 slds-large-size_8-of-12"><div class="slds-form-element_'+ | ||
| '_control"><input type="text" id="input-url-' + (index) + '" class="slds-input" placeholder='+ | ||
| '"URL" /></div></div></div></div>' |
There was a problem hiding this comment.
use concatenation and indentation in string
| </div> | ||
| <script> | ||
| var isEmpty = function(string) { | ||
| return string === ''; |
There was a problem hiding this comment.
check if null or undefined or ''
| } | ||
| } | ||
| </script> | ||
| <apex:slds /> |
There was a problem hiding this comment.
better to move to top
| @@ -1,8 +1,15 @@ | |||
| # Upload to SharinPix using URL | |||
There was a problem hiding this comment.
README modified - added backticks and markdown syntax instead of html tags
useful link - https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet
| sharinpix.Utils utils = new sharinpix.Utils(); | ||
| utils.uploadFromUrl(url, albumId, filename); | ||
| } | ||
|
|
src/package.xml
Outdated
| <name>ApexPage</name> | ||
| </types> | ||
| <types> | ||
| <members>SharinPixImageFromUrlsDemo</members> |
There was a problem hiding this comment.
suffix: Controller / Ctrl
| <div class="slds-notify_container slds-is-relative"> | ||
| <div class="slds-notify slds-notify_toast slds-theme_success" role="alert"> | ||
| <div class="slds-notify__content"> | ||
| <h2 class="slds-text-heading_small ">Your images was send for upload.</h2> |
No description provided.