notes

Shazwazza · Sep 26, 2024 · fdcf98e · fdcf98e
1 parent dc0b886
commit fdcf98e
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/Examine.Lucene/Search/LuceneSearchExecutor.cs b/src/Examine.Lucene/Search/LuceneSearchExecutor.cs
@@ -128,9 +128,12 @@ public ISearchResults Execute()
 
                 var results = new List<LuceneSearchResult>(topDocs.ScoreDocs.Length);
 
-                // Order by Doc Id for improved perf!
+                // TODO: Order by Doc Id for improved perf??
+                // Our benchmarks show this is isn't a significant performance improvement,
+                // but they could be wrong. Sorting by DocId here could only be done if there
+                // are no sort options.
                 // See https://cwiki.apache.org/confluence/display/lucene/ImproveSearchingSpeed
-                foreach (var scoreDoc in topDocs.ScoreDocs/*.OrderBy(x => x.Doc)*/)
+                foreach (var scoreDoc in topDocs.ScoreDocs)
                 {
                     var result = GetSearchResult(scoreDoc, topDocs, searcher.IndexSearcher);
                     results.Add(result);