Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4.0 Bugfix Index Float field as a Single #365

Open
wants to merge 3 commits into
base: release/4.0
Choose a base branch
from

Conversation

nzdev
Copy link
Contributor

@nzdev nzdev commented Dec 7, 2023

The "Float" field type indexes as a Double in V3.
Adds "Single" for the existing behavior, Float now indexes as a Single.

This would be a breaking change for V3.

@Shazwazza
Copy link
Owner

Should we just fix the SingleType instead of introducing FloatType? If we continue with FloatType, then should SingleType be obsoleted?

@nzdev
Copy link
Contributor Author

nzdev commented Apr 4, 2024

I think just fixing the SingleType would be preferable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants