Fix import staging script #764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The import staging script was choking on the bookmarks table due to it having a column named "order", which is a reserved keyword in pgsql. This PR enhances our staging_importer#fast_insert method by quoting table name and column name and thus preventing this from happening with other reserved words.
schroerbrian
force-pushed
the
brian-fix-import-staging-script
branch
from
5416cee to
9073993
Compare
richardxia
approved these changes
Jan 29, 2026
Member
richardxia
left a comment
richardxia
left a comment
There was a problem hiding this comment.
LGTM! Thanks for fixing this!
Contributor
Author
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The import staging script was choking on the bookmarks table due to it having a column named "order", which is a reserved keyword in pgsql. This PR enhances our staging_importer#fast_insert method by quoting table name and column name and thus preventing this from happening with other reserved words.