Skip to content

feat(web): enforce image limits with warning UX, clamp rectangle count, and add “Important Notice & Disclaimer”#11

Merged
Shimo-1999 merged 5 commits intomainfrom
feature/limit-file-and-rects
Oct 21, 2025
Merged

feat(web): enforce image limits with warning UX, clamp rectangle count, and add “Important Notice & Disclaimer”#11
Shimo-1999 merged 5 commits intomainfrom
feature/limit-file-and-rects

Conversation

@Shimo-1999
Copy link
Owner

No description provided.

@github-actions
Copy link
Contributor

🚀 Preview is ready

"https://Shimo-1999.github.io/rectangle-fitting/pr-preview-11/"

This link auto-updates on every push to this PR.

github-actions bot added a commit that referenced this pull request Oct 21, 2025
@Shimo-1999 Shimo-1999 requested a review from Copilot October 21, 2025 15:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces image validation with user-facing warnings, enforces limits on rectangle count, and adds a disclaimer modal. The changes improve user experience by preventing browser crashes from oversized images while providing clear feedback when limits are exceeded.

Key changes:

  • Added image size/resolution validation (15MB, 20MP, 8192px max dimensions) with warning UI
  • Clamped rectangle count input to 1-5000 range with wheel event prevention
  • Added modal disclaimer about potential browser issues with large images

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
web/js/script.js Implements LIMITS constants, validation logic for images, warning UI system, and rectangle count clamping
web/index.html Adds notice container, disclaimer modal, updates default rectangle count to 500, adds Bootstrap bundle script
README.md Corrects license file path and adds disclaimer section

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-actions
Copy link
Contributor

🚀 Preview is ready

"https://Shimo-1999.github.io/rectangle-fitting/pr-preview-11/"

This link auto-updates on every push to this PR.

@Shimo-1999 Shimo-1999 merged commit 847cded into main Oct 21, 2025
4 checks passed
github-actions bot added a commit that referenced this pull request Oct 21, 2025
@Shimo-1999 Shimo-1999 deleted the feature/limit-file-and-rects branch October 21, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants