Add adjustable SVG stroke width (0px = off)#12
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds an adjustable stroke width control for SVG rendering, allowing users to customize the border thickness of rectangles or hide them entirely by setting the width to 0px.
- Adds a new "stroke" input control to the UI with a default value of 0.5px
- Passes stroke width parameter through all SVG generation and rendering functions
- Implements conditional stroke rendering in Rust WASM code (0px = no stroke)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| web/index.html | Adds stroke width input control to UI toolbar and updates layout widths |
| web/js/script.js | Adds stroke width element reference, event handlers, and passes value to all visSvg calls |
| wasm/src/lib.rs | Updates vis_svg function to accept stroke_width parameter and conditionally apply stroke attributes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
🚀 Preview is ready "https://Shimo-1999.github.io/rectangle-fitting/pr-preview-12/" This link auto-updates on every push to this PR. |
|
🚀 Preview is ready "https://Shimo-1999.github.io/rectangle-fitting/pr-preview-12/" This link auto-updates on every push to this PR. |
|
🚀 Preview is ready "https://Shimo-1999.github.io/rectangle-fitting/pr-preview-12/" This link auto-updates on every push to this PR. |
No description provided.