-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Dashboard Missing Ep+Tmdb Link Shortcuts / Collection Tag Links and Sticky Searchbar+Sidebars #1093
Open
natyusha
wants to merge
16
commits into
ShokoAnime:master
Choose a base branch
from
natyusha:patch-filterlinks
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- give the hover edit button a tooltip to match the ones with the same style on the series page - make the list view posters slightly larger to stop the two column layout from having slightly different sizes depending on how much text is in the description
- add the same behavior as the ones on the series page - this will open the edit tag condition modal which seems like a bonus - add a tooltip to the tags so the user knows what clicking it does
- slightly reduced top nav vertical padding - converted the timeline sidebar into a ShokoPanel like the filter one (for scrolling)
natyusha
changed the title
Add: Dashboard Missing Episode+TMDB Link Shortcuts / Collection List View Tag Links
Add: Dashboard Missing Ep+Tmdb Link Shortcuts / Collection Tag Links and Sticky Searchbar+Sidebars
Oct 4, 2024
- seems more user friendly to keep the non tag filters in case an entire filter stack is overwritten
- allows for a four instead of three column poster layout with a 1440px window width and the sidebars open - also makes the sidebar panel gap match the series page/dashboard as it was larger before
harshithmohan
requested changes
Oct 7, 2024
- added missing hover transitions across the webui - changed the timeline panel slightly so the poster has the same hover transition/zoom as posters elsewhere - also make the timeline link only active when hovering the poster so the text can be selected - changed link state variable name for taglinks
- also remove pointless transition all for ratings
natyusha
force-pushed
the
patch-filterlinks
branch
from
October 7, 2024 11:12
9b12d87
to
c99f19e
Compare
harshithmohan
requested changes
Oct 7, 2024
- change poster view behavior to match - add missing edit group hover transition
- also move the title from the parent to the link itself for the collection poster/list views
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
should cover this issue: #1084