Skip to content

Conversation

@isaacroldan
Copy link
Contributor

@isaacroldan isaacroldan commented Oct 17, 2025

WHY are these changes introduced?

Upgrade TypeScript configuration and React to version 19.1.0 to leverage newer language features and improve performance.

WHAT is this pull request doing?

  • Updates TypeScript configuration in tsconfig.json to use ES2023 and Bundler module resolution
  • Upgrades React from 17.0.2/18.x to 19.1.0 across all packages
  • Upgrades Ink from 4.4.1 to 6.3.1 for compatibility with React 19
  • Updates React-related type definitions to match the new version
  • Fixes ignore module imports to use the direct import syntax

How to test your changes?

  1. Run the test suite to ensure all tests pass with the new React version
  2. Test the CLI functionality to verify it works correctly with the updated dependencies
  3. Verify that the bundled output works as expected with the splitting disabled

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@isaacroldan isaacroldan force-pushed the 10-16-update_build_system_and_dependencies branch from cf179f7 to b56cd79 Compare October 17, 2025 10:49
@isaacroldan isaacroldan changed the title Update build system and dependencies Update Ink and React dependencies Oct 17, 2025
@isaacroldan isaacroldan marked this pull request as ready for review October 17, 2025 10:49
@isaacroldan isaacroldan requested a review from a team as a code owner October 17, 2025 10:49
Copy link
Contributor Author

/snapit

@isaacroldan isaacroldan force-pushed the 10-16-update_build_system_and_dependencies branch from b56cd79 to 5f661b2 Compare October 17, 2025 10:51
@github-actions
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

Copy link
Contributor Author

/snapit

1 similar comment
Copy link
Contributor Author

/snapit

@isaacroldan isaacroldan force-pushed the 10-16-update_build_system_and_dependencies branch 2 times, most recently from a6fb6df to eea8688 Compare October 17, 2025 13:02
@isaacroldan isaacroldan force-pushed the 10-16-update_build_system_and_dependencies branch from eea8688 to e8da982 Compare October 17, 2025 15:23
@github-actions
Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/error.d.ts
@@ -38,8 +38,6 @@ export declare abstract class FatalError extends Error {
  * Those usually represent unexpected scenarios that we can't handle and that usually require some action from the developer.
  */
 export declare class AbortError extends FatalError {
-    nextSteps?: TokenItem<InlineToken>[];
-    customSections?: AlertCustomSection[];
     constructor(message: TokenItem | OutputMessage, tryMessage?: TokenItem | OutputMessage | null, nextSteps?: TokenItem<InlineToken>[], customSections?: AlertCustomSection[]);
 }
 /**

@isaacroldan isaacroldan marked this pull request as draft October 17, 2025 15:29
@github-actions
Copy link
Contributor

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant