Skip to content

Update Ink and React #6530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update Ink and React #6530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions configurations/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"compileOnSave": false,
"compilerOptions": {
"lib": ["ES2020"],
"target": "ES2020",
"lib": ["ES2023"],
"target": "ES2023",
Copy link
Contributor Author

@isaacroldan isaacroldan Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ink's new version forced this

"module": "NodeNext",
"moduleResolution": "NodeNext",
"esModuleInterop": true,
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
"octokit-plugin-create-pull-request": "^3.12.2",
"pathe": "1.1.1",
"pin-github-action": "^3.3.1",
"react": "17.0.2",
"react": "19.1.0",
"rimraf": "^3.0.2",
"tmp": "^0.2.4",
"ts-node": "^10.9.1",
Expand Down
8 changes: 4 additions & 4 deletions packages/app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@
"http-proxy-node16": "1.0.6",
"ignore": "6.0.2",
"proper-lockfile": "4.1.2",
"react": "^18.2.0",
"react-dom": "18.3.1",
"react": "^19.1.0",
"react-dom": "19.1.0",
"which": "4.0.0",
"ws": "8.18.0"
},
Expand All @@ -79,8 +79,8 @@
"@types/diff": "^5.0.3",
"@types/express": "^4.17.17",
"@types/proper-lockfile": "4.1.4",
"@types/react": "18.2.0",
"@types/react-dom": "18.2.0",
"@types/react": "19.1.0",
"@types/react-dom": "19.1.0",
"@types/which": "3.0.4",
"@types/ws": "^8.5.13",
"@vitest/coverage-istanbul": "^3.1.4"
Expand Down
4 changes: 2 additions & 2 deletions packages/cli-kit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
"graphql": "16.10.0",
"graphql-request": "6.1.0",
"ignore": "6.0.2",
"ink": "4.4.1",
"ink": "6.3.1",
"is-executable": "2.0.1",
"is-interactive": "2.0.0",
"is-wsl": "3.1.0",
Expand All @@ -152,7 +152,7 @@
"node-fetch": "3.3.2",
"open": "8.4.2",
"pathe": "1.1.2",
"react": "^18.2.0",
"react": "^19.1.0",
"semver": "7.6.3",
"simple-git": "3.27.0",
"stacktracey": "2.1.8",
Expand Down
3 changes: 0 additions & 3 deletions packages/cli-kit/src/public/node/error.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,6 @@ export abstract class FatalError extends Error {
* Those usually represent unexpected scenarios that we can't handle and that usually require some action from the developer.
*/
export class AbortError extends FatalError {
nextSteps?: TokenItem<InlineToken>[]
customSections?: AlertCustomSection[]

Copy link
Contributor Author

@isaacroldan isaacroldan Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new ES2023 triggered an error here because these properties already exist in FatalError

constructor(
message: TokenItem | OutputMessage,
tryMessage: TokenItem | OutputMessage | null = null,
Expand Down
Loading
Loading