fix missing json output for theme info command when dev and theme flags are missing

[FKauwe]

WHY are these changes introduced?

Fixes #1064 : Theme info not outputting json with the --json flag

I identified that when running shopify theme info --json without a --theme or --development flag, execution goes to the else branch, which had no JSON handling. The JSON.stringify logic only existed in the if branch (which requires --theme or --development)

The else branch had no --json handling at all, so the flag was silently ignored.

WHAT is this pull request doing?

I could have chosen to jsonify the existing info message, but this was formulated for the tabular data to output the formatted box in the terminal and looks messy and is more difficult to parse. It would have looked like this:

Click to expand

Output:

[
  {
    "title": "Theme Configuration PROOF OF WHERE I AM",
    "body": {
      "tabularData": [
        [
          "Store",
          "f9e81e-af.myshopify.com"
        ],
        [
          "Development Theme ID",
          {
            "subdued": "Not set"
          }
        ]
      ],
      "firstColumnSubdued": true
    }
  },
  {
    "title": "Tooling and System",
    "body": {
      "tabularData": [
        [
          "Shopify CLI",
          "3.91.0"
        ],
        [
          "OS",
          "darwin-arm64"
        ],
        [
          "Shell",
          "/bin/zsh"
        ],
        [
          "Node version",
          "v23.6.1"
        ]
      ],
      "firstColumnSubdued": true
    }
  }
]

I chose to make a new, more easily parse-able json object (following the pattern of the if branch, where a clean object is also created specifically to be consumed by JSON.stringify). I built a new Interface and function to populate the object in packages/theme/src/cli/services/info.ts, then consumed it in the else branch in packages/theme/src/cli/commands/theme/info.ts

I wrote a new unittest to verify that the JSON conversion is working correctly.
All existing tests pass.

How to test your changes?

while on main, run shopify theme info --json, should see no json and formulated tabular info like this:

then pull down my branch locally,
p build ,
run shopify-dev theme info --json
see the nice JSON formatting!

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

[binks-code-reviewer]

🤖 Code Review · #projects-dev-ai for questions
React with 👍/👎 or reply — all feedback helps improve the agent.

✅ Complete - No issues

📋 History

✅ 1 findings → ✅ No issues

[binks-code-reviewer]

⚠️ Findings outside the diff

These findings are in files not modified by this PR and cannot be posted as inline comments.

---

packages/theme/src/cli/commands/theme/info.ts:38 — Duplicate timing event recorded (double recordTiming)

recordTiming('theme-command:info') is called at the start of command() and again at the end. With the new early return in the else branch (flags.json), behavior becomes inconsistent:

• JSON path: timing recorded only once (line 38), because you return early.
• Non-JSON path: timing recorded twice (line 38 and line 58).
  This can skew analytics, dashboards, and latency tracking, potentially making it look like the command ran twice or distorting timing distribution for this command.

[EvilGenius13]

Could we rename this to ThemeEnvironmentInfo?

[EvilGenius13]

This took me a minute to understand. If you don't want to make it more verbose can we wrap the first part in () so like development_theme_id: store ? (getDevelopmentTheme() ?? null) : null, ? That way you can more easily ready that it's getDevelopmentTheme that may return null OR that if store isn't found we don't want to run that method and skip right to null as well.

[EvilGenius13]

It looks like we're calling flags.json twice now. Can you look into merging that logic?