add severity level support for all linters #349
+75
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #348.
Introduce a severity level of
:error
by default to all the linters that does not have a configured severity level. Introducing a new severity level property in the linter configuration we achieve that now all the linters can have aseverity
property in the.erb-lint.yml
.Because currently the linter already has support for some compatibility with the severity levels of rubocop, this change only extends the same behaviour but for all linters.
This permits for example to omit the errors of
MyCustomLinter
when runningerblint foo.erb
with the following configurationThis is useful to introduce linters in a codebease in an incremental manner, to configure to not throw errors when introducing a linter but still seeing it in the editor, for example when running the linter in CI.