Automated fix for refs/heads/rwstauner/mark-channel-creds#42
Open
github-actions[bot] wants to merge 2 commits intorwstauner/mark-channel-credsfrom
Open
Automated fix for refs/heads/rwstauner/mark-channel-creds#42github-actions[bot] wants to merge 2 commits intorwstauner/mark-channel-credsfrom
github-actions[bot] wants to merge 2 commits intorwstauner/mark-channel-credsfrom
Conversation
The credentials object potentially holds a reference to a proc when composed with CallCredentials. We need the proc to live so that when requests build the credentials the proc can still be invoked. For the proc to live we need the credentials object to live so it needs to be marked by the channel. Co-authored-by: Ufuk Kayserilioglu <ufuk.kayserilioglu@shopify.com> Co-authored-by: Peter Zhu <peter.zhu@shopify.com> Co-authored-by: Kevin Menard <kevin.menard@shopify.com>
rwstauner
force-pushed
the
rwstauner/mark-channel-creds
branch
from
e599c3d to
48c11d4
Compare
paracycle
force-pushed
the
rwstauner/mark-channel-creds
branch
from
48c11d4 to
d1d58eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PanCakes to the rescue!
We noticed that our 'sanity' test was going to fail, but we think we can fix that automatically, so we put together this PR to do just that!
If you'd like to opt-out of these PR's, add yourself to NO_AUTOFIX_USERS in .github/workflows/pr-auto-fix.yaml