Skip to content

Automated fix for refs/heads/rwstauner/mark-channel-creds #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 2 commits into
base: rwstauner/mark-channel-creds
Choose a base branch
from
Open

Automated fix for refs/heads/rwstauner/mark-channel-creds #43

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48c11d4
Ruby: Mark credential object in channel
rwstauner Aug 5, 2025
55b2428
Automated change: Fix sanity tests
rwstauner Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions src/ruby/ext/grpc/rb_channel.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ static VALUE grpc_rb_cChannelArgs;
/* grpc_rb_channel wraps a grpc_channel. */
typedef struct grpc_rb_channel {
grpc_channel* channel;
VALUE mark;
} grpc_rb_channel;

static void grpc_rb_channel_free(void* p) {
Expand All @@ -76,13 +77,19 @@ static void grpc_rb_channel_free(void* p) {
xfree(p);
}

static rb_data_type_t grpc_channel_data_type = {
"grpc_channel",
{NULL, grpc_rb_channel_free, GRPC_RB_MEMSIZE_UNAVAILABLE, {NULL, NULL}},
NULL,
NULL,
static void grpc_rb_channel_mark(void* p) {
rb_gc_mark(((grpc_rb_channel*)p)->mark);
}

static rb_data_type_t grpc_channel_data_type = {"grpc_channel",
{grpc_rb_channel_mark,
grpc_rb_channel_free,
GRPC_RB_MEMSIZE_UNAVAILABLE,
{NULL, NULL}},
NULL,
NULL,
#ifdef RUBY_TYPED_FREE_IMMEDIATELY
RUBY_TYPED_FREE_IMMEDIATELY
RUBY_TYPED_FREE_IMMEDIATELY
#endif
};

Expand All @@ -91,6 +98,7 @@ static VALUE grpc_rb_channel_alloc(VALUE cls) {
grpc_ruby_init();
grpc_rb_channel* wrapper = ALLOC(grpc_rb_channel);
wrapper->channel = NULL;
wrapper->mark = Qnil;
return TypedData_Wrap_Struct(cls, &grpc_channel_data_type, wrapper);
}

Expand Down Expand Up @@ -139,6 +147,7 @@ static VALUE grpc_rb_channel_init(int argc, VALUE* argv, VALUE self) {
return Qnil;
}
wrapper->channel = grpc_channel_create(target_chars, creds, &channel_args);
wrapper->mark = rb_credentials;
}
grpc_rb_channel_args_destroy(&channel_args);
if (wrapper->channel == NULL) {
Expand Down