Open
Conversation
6ddb6f6 to
750aa23
Compare
750aa23 to
fd3871d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
diff.rsmodule that can be used to compare two different graphs. This could be useful for a couple of different cases:assert_incremental_graph_identical!which validates the incrementally updated graph matches a fresh graph with the same source input. I have also been using anincremental_verifytool (similar to thedifftool in this PR) to compare incremental updates between different git references. This has been really useful in validating that the incremental update prototypes (don't yet) work correctly.I wasn't sure how to make this tool a development only entry point, so I added aI switched to an example instead but I'm not sure that's right either.dev-toolsfeature, which I believe means it won't be published? Though I'm not sure about this, would like some feedback or ideas.Example outputs