Fix connection error message regexp for Mysql2 #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianna-chang-shopify
force-pushed
the
ac-fix-mysql2-conn-regexp
branch
from
753e44c
to
5cc1a0f
Compare
nvasilevski
approved these changes
Oct 26, 2023
In CI, sometimes the Mysql2 error message for a lost connection doesn't include "MySQL server", it says "Lost connection to server". This commit makes the "MySQL" part of the regexp optional. Co-authored-by: Nikita Vasilevsky <nikita.vasilevsky@shopify.com>
adrianna-chang-shopify
force-pushed
the
ac-fix-mysql2-conn-regexp
branch
from
5cc1a0f
to
510978d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CI, sometimes the Mysql2 error message for a lost connection doesn't include "MySQL server", it says "Lost connection to server". (Example: https://github.com/Shopify/semian/actions/runs/6658049618/job/18094086273#step:7:37)
This commit makes the "MySQL" part of the regexp optional.
This will fix failing CI.