Skip to content

Conversation

nasudadada
Copy link
Contributor

@nasudadada nasudadada commented Jan 11, 2025

Fix: Upgrade pre-commit dependencies to resolve CI failures

WHY are these changes introduced?

Fixes #754

Pre-commit checks are failing in GitHub Actions with the current dependencies. This is blocking other PRs like #752 and #753.

WHAT is this pull request doing?

  • Upgrades pre-commit dependencies to their latest versions:
    • pylint: v2.15.8 -> v3.3.3
    • black: 22.3.0 -> 24.10.0
    • pre-commit-hooks: v3.4.0 -> v5.0.0
  • Fixes new pylint warnings introduced by the upgrade

If this approach isn't aligned with the project's direction, please let me know and I'll be happy to close this PR.

Checklist

  • I have updated the CHANGELOG (if applicable)
  • I have followed the Shopify Python guide

Copy link
Contributor

@sle-c sle-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for fixing this!

@sle-c sle-c merged commit 89731eb into Shopify:main Jan 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pre-commit checks failing in GitHub Actions with Python 3.12(ubuntu:latest)

2 participants