Refactor and cleanup treatment of keyspace IDs and KeyRange#140
Closed
shanth96 wants to merge 1 commit intov15.0.3-shopify-1from
Closed
Refactor and cleanup treatment of keyspace IDs and KeyRange#140shanth96 wants to merge 1 commit intov15.0.3-shopify-1from
shanth96 wants to merge 1 commit intov15.0.3-shopify-1from
Conversation
Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com> Address internal review comments Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com> Fix apparent bug in KeyRangeContiguous when a or b are full-range Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com> Add test for bug in comparing "0003" vs "000300" Signed-off-by: Hormoz Kheradmand <hormoz.kheradmand@shopify.com> Remove trailing zeroes in key.Normalize instead of adding padding Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com> Address review feedback; test formatting, comments, function naming Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com> Refactor tests for TestKeyRangesIntersect Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com> Rename KeyRangesIntersect to KeyRangeIntersect for consistency Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com> Remove unused KeyRangesOverlap function Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com> Rename KeyRangeIncludes to KeyRangeContainsKeyRange, clean up and add tests Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com>
shanth96
added
Available: nil
Available: 17.0.0
and removed
Available: 17.0.0
Available: nil
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address internal review comments
Fix apparent bug in KeyRangeContiguous when a or b are full-range
Add test for bug in comparing "0003" vs "000300"
Remove trailing zeroes in key.Normalize instead of adding padding
Address review feedback; test formatting, comments, function naming
Refactor tests for TestKeyRangesIntersect
Rename KeyRangesIntersect to KeyRangeIntersect for consistency
Remove unused KeyRangesOverlap function
Rename KeyRangeIncludes to KeyRangeContainsKeyRange, clean up and add tests
Description
Related Issue(s)
Checklist
Deployment Notes