Skip to content

V16.0.7 shopify 1 release #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from

Conversation

shanth96
Copy link

@shanth96 shanth96 commented Feb 28, 2024

jeremycole and others added 4 commits February 28, 2024 16:10
Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com>

Sprinkle addPadding everywhere when comparing KeyRange Start/End values

Implement support for PartialVindex usage

Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com>
Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com>

Address internal review comments

Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com>

Fix apparent bug in KeyRangeContiguous when a or b are full-range

Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com>

Add test for bug in comparing "0003" vs "000300"

Signed-off-by: Hormoz Kheradmand <hormoz.kheradmand@shopify.com>

Remove trailing zeroes in key.Normalize instead of adding padding

Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com>

Address review feedback; test formatting, comments, function naming

Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com>

Refactor tests for TestKeyRangesIntersect

Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com>

Rename KeyRangesIntersect to KeyRangeIntersect for consistency

Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com>

Remove unused KeyRangesOverlap function

Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com>

Rename KeyRangeIncludes to KeyRangeContainsKeyRange, clean up and add tests

Signed-off-by: Jeremy Cole <jeremy.cole@shopify.com>
Signed-off-by: austenLacy <austenlacy@gmail.com>
Signed-off-by: Austen Lacy <austen.lacy@shopify.com>
Co-authored-by: Austen Lacy <austen.lacy@shopify.com>
@shanth96 shanth96 mentioned this pull request Mar 20, 2024
@shanth96 shanth96 changed the title V16.0.7 shopify 1 script test V16.0.7 shopify 1 release Mar 20, 2024
austenLacy and others added 8 commits March 20, 2024 13:44
* purge old schema versions from memory in historian

Signed-off-by: austenLacy <austenlacy@gmail.com>

* fix vttablet arg e2e test

Signed-off-by: Austen Lacy <austen.lacy@shopify.com>

* only reassign historian schemas if necessary

Signed-off-by: Austen Lacy <austen.lacy@shopify.com>

* dont use from_unixtime in query because already in unix

Signed-off-by: Austen Lacy <austen.lacy@shopify.com>

---------

Signed-off-by: austenLacy <austenlacy@gmail.com>
Signed-off-by: Austen Lacy <austen.lacy@shopify.com>
Co-authored-by: Austen Lacy <austen.lacy@shopify.com>
…t-vindex

Generate CachedSize function for Placement vindex
…sio#13065) (#107)

Co-authored-by: Hormoz Kheradmand <hkdsun@users.noreply.github.com>
…ssio#13913) (#122)

* Properly support ignore_nulls in CreateLookupVindex (vitessio#13913)

Signed-off-by: Matt Lord <mattalord@gmail.com>

* remove new vreplication tests that dont work with v15

Signed-off-by: Austen Lacy <austen.lacy@shopify.com>

---------

Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Austen Lacy <austen.lacy@shopify.com>
Co-authored-by: Matt Lord <mattalord@gmail.com>
Co-authored-by: Austen Lacy <austen.lacy@shopify.com>
…ication status (vitessio#14436) (#128)

Signed-off-by: Austen Lacy <austen.lacy@shopify.com>
Co-authored-by: Austen Lacy <austen.lacy@shopify.com>
…r-id-error-with-consistent-lookup-vindexes

Backport: Vindexes: Pass context in consistent lookup handleDup (vitessio#14653)
Run all relevant tests on all PRs
@shanth96 shanth96 force-pushed the v16.0.7-shopify-1-script-test branch from ad9e33b to 8cc24fa Compare March 20, 2024 17:45
@shanth96
Copy link
Author

Closing in favour of #149

@shanth96 shanth96 closed this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants