Clarify unsafe code directives in README #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated README to clarify rules regarding unsafe code and comments.
Jakobus42
reviewed
Nov 7, 2025
| - `unsafe fn` means **_'know what you are doing before calling this function'_**. | ||
| - `unsafe trait` means **_'know what you are doing before implementing this trait'_**. | ||
| - `unsafe {}` and `unsafe impl` both mean **_'I know what I am doing'_**. | ||
| - `unsafe {}` and `unsafe impl` both mean **_'I know what I am doing, let me cook'_**. |
Collaborator
Author
There was a problem hiding this comment.
i look at these subjects every once in a while and i just want to change everything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated README to clarify rules regarding unsafe code and comments.