-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update list object options, add slab encryption key and make bucket optional #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjan
commented
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased this PR to api-breakers
since it's removing an endpoint the UI uses
8 tasks
peterjan
force-pushed
the
pj/list-by-slab-key
branch
from
September 16, 2024 07:29
b8fe3c2
to
23646fb
Compare
peterjan
changed the title
Allow listing objects by slab key and make bucket an optional parameter
Update list object options, add slab encryption key and make bucket optional
Sep 16, 2024
ChrisSchinnerl
approved these changes
Sep 17, 2024
ChrisSchinnerl
added a commit
that referenced
this pull request
Oct 23, 2024
This is a temporary branch to merge PRs into that break the UI. Once this is complete, we can update the UI in a single version, update the version in this branche's `go.mod`, test that it is working and then merge everything at once. Required Updates: - [x] `/account/:id/resetdrift` moved to worker (#1464) - [x] `/search/hosts` to `/hosts` (#1484) - [x] `/wallet` (#1478) - [x] `/search/objects` and `/objects/*path` to `/listobjects` (#1493) - [x] gouging settings now use base units (#1505) - [x] removed `/autopilot/host` and `/autopilot/hosts` (#1508) - [x] removed `/slab/:key/objects` and integrated it into the list objects endpoint (#1517) - [x] endpoints no longer default to "default" bucket #1541
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
ListObjectOptions
, makingbucket
optional and addingslabEncryptionKey
. It removes an endpoint and allows fetching objects cross buckets, which we use for migration failure alerts.