Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list object options, add slab encryption key and make bucket optional #1517

Merged
merged 14 commits into from
Sep 17, 2024

Conversation

peterjan
Copy link
Member

@peterjan peterjan commented Sep 9, 2024

This PR updates ListObjectOptions, making bucket optional and adding slabEncryptionKey. It removes an endpoint and allows fetching objects cross buckets, which we use for migration failure alerts.

@peterjan peterjan self-assigned this Sep 9, 2024
bus/routes.go Outdated Show resolved Hide resolved
@peterjan peterjan marked this pull request as ready for review September 11, 2024 08:10
@ChrisSchinnerl ChrisSchinnerl changed the base branch from dev to api-breakers September 12, 2024 11:49
Copy link
Member

@ChrisSchinnerl ChrisSchinnerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased this PR to api-breakers since it's removing an endpoint the UI uses

@peterjan peterjan changed the title Allow listing objects by slab key and make bucket an optional parameter Update list object options, add slab encryption key and make bucket optional Sep 16, 2024
stores/sql/main.go Show resolved Hide resolved
stores/metadata_test.go Outdated Show resolved Hide resolved
stores/metadata_test.go Show resolved Hide resolved
@ChrisSchinnerl ChrisSchinnerl merged commit 22956b5 into api-breakers Sep 17, 2024
7 checks passed
@ChrisSchinnerl ChrisSchinnerl deleted the pj/list-by-slab-key branch September 17, 2024 15:06
ChrisSchinnerl added a commit that referenced this pull request Oct 23, 2024
This is a temporary branch to merge PRs into that break the UI. Once
this is complete, we can update the UI in a single version, update the
version in this branche's `go.mod`, test that it is working and then
merge everything at once.

Required Updates:
- [x] `/account/:id/resetdrift` moved to worker
(#1464)
- [x] `/search/hosts` to `/hosts`
(#1484)
- [x] `/wallet` (#1478)
- [x] `/search/objects` and `/objects/*path` to `/listobjects`
(#1493)
- [x] gouging settings now use base units
(#1505)
- [x] removed `/autopilot/host` and `/autopilot/hosts`
(#1508)
- [x] removed `/slab/:key/objects` and integrated it into the list
objects endpoint (#1517)
- [x] endpoints no longer default to "default" bucket
#1541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants