fix(hostd): alerts list not showing

SiaFoundation · Jan 9, 2025 · 2fda955 · 2fda955
1 parent e1a49ed
commit 2fda955
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 4 deletions.
diff --git a/.changeset/fifty-dogs-study.md b/.changeset/fifty-dogs-study.md
@@ -0,0 +1,5 @@
+---
+'hostd': patch
+---
+
+Fixed an issue where the list of alerts was not showing.
diff --git a/.changeset/strange-ravens-joke.md b/.changeset/strange-ravens-joke.md
@@ -0,0 +1,5 @@
+---
+'@siafoundation/design-system': patch
+---
+
+Fixed an issue where AlertDialog was using the incorrect dataset loaded state.
diff --git a/apps/hostd-e2e/src/fixtures/navigate.ts b/apps/hostd-e2e/src/fixtures/navigate.ts
@@ -44,3 +44,13 @@ export const navigateToContracts = step(
     ).toBeVisible()
   }
 )
+
+export const openAlertsDialog = step(
+  'open alerts dialog',
+  async (page: Page) => {
+    await page.getByTestId('sidenav').getByLabel('Alerts').click()
+    const dialog = page.getByRole('dialog')
+    await expect(dialog.getByText('Alerts')).toBeVisible()
+    return dialog
+  }
+)
diff --git a/apps/hostd-e2e/src/specs/volumes.spec.ts b/apps/hostd-e2e/src/specs/volumes.spec.ts
@@ -1,5 +1,5 @@
 import { expect, test } from '@playwright/test'
-import { navigateToVolumes } from '../fixtures/navigate'
+import { navigateToVolumes, openAlertsDialog } from '../fixtures/navigate'
 import {
   createVolume,
   deleteVolume,
@@ -31,6 +31,9 @@ test('can create and delete a volume', async ({ page }) => {
   const name = 'my-new-volume'
   await navigateToVolumes({ page })
   await createVolume(page, name, dirPath)
+  const dialog = await openAlertsDialog(page)
+  await expect(dialog.getByText('Volume initialized')).toBeVisible()
+  await dialog.getByLabel('close').click()
   await deleteVolume(page, name, dirPath)
 })
 

diff --git a/libs/design-system/src/app/AlertsDialog/index.tsx b/libs/design-system/src/app/AlertsDialog/index.tsx
@@ -57,8 +57,7 @@ export function AlertsDialog({
       alerts.data?.filter((a) => (filter ? a.severity === filter : true)) || [],
     [alerts.data, filter]
   )
-
-  // Sort keys by dataFieldOrder, then alphabetically
+  // Sort keys by dataFieldOrder, then alphabetically.
   const getOrderedKeys = useCallback(
     (obj: Record<string, unknown>) => {
       const orderedKeys = Object.keys(obj).sort((a, b) => {
@@ -164,7 +163,7 @@ export function AlertsDialog({
           </div>
         )}
         {loadingState === 'loading' && <EntityListSkeleton />}
-        {!loadingState && (
+        {loadingState === 'loaded' && (
           <div className="flex flex-col">
             {dataset.length ? (
               dataset.map((a) => (