Skip to content

refactor(explorer): hastings to fiat method name #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Mar 26, 2025

  • Small change to make method name more specific/accurate.

@Copilot Copilot AI review requested due to automatic review settings March 26, 2025 20:40
Copy link

changeset-bot bot commented Mar 26, 2025

⚠️ No Changeset found

Latest commit: f8782b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2025 1:50pm
explorer-zen ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2025 1:50pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
hostd ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2025 1:50pm
renterd ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2025 1:50pm
website ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2025 1:50pm

@github-project-automation github-project-automation bot moved this to In Progress in Sia Mar 26, 2025
Copy link
Member Author

alexfreska commented Mar 26, 2025

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the currency conversion function by renaming siacoinToFiat to hastingsToFiat to better reflect the unit being converted. Key changes include:

  • Updating the function name and its usage in HostSettings.tsx.
  • Renaming the conversion function in lib/currency.ts.
  • Adjusting function calls in Contract/index.tsx and opengraph-image.tsx to utilize the new name.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
apps/explorer/components/Host/HostSettings.tsx Updated import and function calls to use hastingsToFiat
apps/explorer/lib/currency.ts Renamed siacoinToFiat to hastingsToFiat and updated parameter accordingly
apps/explorer/components/Contract/index.tsx Updated import and conversion function usage
apps/explorer/app/contract/[id]/opengraph-image.tsx Updated import and conversion function usage

Copy link
Member Author

alexfreska commented Mar 27, 2025

Merge activity

  • Mar 27, 10:42 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Mar 27, 10:45 AM EDT: Graphite couldn't merge this PR because it failed for an unknown reason.
  • Mar 27, 1:36 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Mar 27, 1:39 PM EDT: Graphite couldn't merge this PR because it failed for an unknown reason.
  • Mar 27, 5:05 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Mar 27, 5:08 PM EDT: Graphite couldn't merge this PR because it failed for an unknown reason.
  • Mar 27, 5:35 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Mar 27, 5:37 PM EDT: Graphite couldn't merge this PR because it failed for an unknown reason.
  • Mar 27, 6:47 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Mar 27, 6:48 PM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 27, 6:52 PM EDT: Graphite couldn't merge this PR because it failed for an unknown reason.
  • Mar 28, 9:57 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Mar 28, 9:57 AM EDT: A user merged this pull request with Graphite.

@alexfreska alexfreska force-pushed the refactor_explorer_hastings_to_fiat_method_name branch from 99ba98c to f8782b5 Compare March 28, 2025 13:36
@alexfreska alexfreska merged commit d95a0d4 into main Mar 28, 2025
41 checks passed
@alexfreska alexfreska deleted the refactor_explorer_hastings_to_fiat_method_name branch March 28, 2025 13:57
@github-project-automation github-project-automation bot moved this from In Progress to Done in Sia Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants