test(explorer): disable contract renewedFrom, renewedTo, and adjust constant

[telestrial]

This disables the tests that will fail as a result of disabling the renewedFrom and renewedTo buttons until such time as those are available. That said, the next PR up the stack will fail. The one after that I'm aiming to succeed with this PR. The final one, adjusting the testing suite to fully utilize clusterd, obviously changes all this. I wanted to see the pre-cluster testing succeed to verify assumptions, if that makes sense.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
explorer	⬜️ Ignored (Inspect)	Visit Preview		Apr 4, 2025 7:11pm
explorer-zen	⬜️ Ignored (Inspect)	Visit Preview		Apr 4, 2025 7:11pm
hostd	⬜️ Ignored (Inspect)	Visit Preview		Apr 4, 2025 7:11pm
renterd	⬜️ Ignored (Inspect)	Visit Preview		Apr 4, 2025 7:11pm
website	⬜️ Ignored (Inspect)	Visit Preview		Apr 4, 2025 7:11pm

[changeset-bot]

⚠️ No Changeset found

Latest commit: 943069a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[telestrial]

• test(explorer): use cluster for testing #1027
• feat(explorer): add support for v2 types #1018
• feat(explored-types): add v2 type support #1017
• test(explorer): disable contract renewedFrom, renewedTo, and adjust constant #1026 👈 (View in Graphite)
• refactor(request): narrow to() function response type #1032
• feat(explored-types): add explorerTip route #1034
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull Request Overview

This PR disables tests for renewed contract navigation and updates a constant value.

• Comments out test cases for renewedFrom and renewedTo contract navigation.
• Adjusts the constant for missed proof outputs in the contract fixture.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
apps/explorer-e2e/src/specs/contract.spec.ts	Disables tests for renewed contract navigation by commenting out code.
apps/explorer-e2e/src/fixtures/constants.ts	Updates the missedProofTitle constant to reflect a changed output value.

Comments suppressed due to low confidence (2)

apps/explorer-e2e/src/specs/contract.spec.ts:40

• [nitpick] Consider using test.skip to disable tests instead of commenting out the test block. This will maintain discoverability and clarity in the test suite.

// test('contract can navigate to renewed from contract', async ({ page }) => {

apps/explorer-e2e/src/fixtures/constants.ts:69

• Verify that the update to 'missedProofTitle' from '(2)' to '(3)' is intentional and that associated test expectations are updated accordingly.

missedProofTitle: 'Missed proof outputs (3)',

[peterjan]

I'm probably just missing something with all the commenting things out?

[alexfreska]

If those renewed ID fields are being added in the next days or week why don't we leave these tests failing (which is accurate) and once the fields are added we can naturally fix them, meanwhile we can continue working up the stack. If it will be a while then I get the value in disabling and being able to merge the stack.

[telestrial]

@peterjan: We're extending explored to offer renewedFrom and renewedTo on v1 and v2 contracts. Right now, this takes four network requests on v1 and it may not be possible, sticking to core types and current API offerings, for a v2 contract. This should all eventually be uncommented, including the stuff in the second PR above.

That said, @alexfreska, I don't mind closing! I don't know when this feature will be live in main explored and ready to be developed against, so that's where I'm coming from with it. It sounds like, from discussion, the PR may hit Friday. It then needs review. It could be available Friday. Maybe Monday. Could be next Friday. It's hard to predict.

[alexfreska]

Go ahead and merge if its easier, and we can uncomment whenever that feature lands.

[telestrial]

Merge activity

• Apr 4, 3:02 PM EDT: A user started a stack merge that includes this pull request via Graphite.
• Apr 4, 3:11 PM EDT: Graphite rebased this pull request as part of a merge.
• Apr 4, 3:15 PM EDT: A user merged this pull request with Graphite.