Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ipv6 connect peer and block host #625

Merged
merged 1 commit into from
May 17, 2024
Merged

fix: ipv6 connect peer and block host #625

merged 1 commit into from
May 17, 2024

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented May 13, 2024 •
edited
Loading

This PR adjusts the client-side validation for IPs.

  • The connect to peer dialog now supports IPv6 addresses.
  • The host blocklist dialog now supports adding IPv6 addresses.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 13, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: b36a438

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
renterd Minor
hostd Minor
walletd Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexfreska Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alexfreska and the rest of your teammates on Graphite Graphite

ChrisSchinnerl
ChrisSchinnerl reviewed May 17, 2024
View reviewed changes
Copy link
Member

@ChrisSchinnerl ChrisSchinnerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Nate. Probably fine to drop validation in both places.

@alexfreska alexfreska force-pushed the fix_ipv6_connect_peer_and_block_host branch from 633a256 to b36a438 Compare May 17, 2024 19:41
@alexfreska
Copy link
Member Author

@n8maninger @ChrisSchinnerl validation removed in both spots, and the regexes deleted forever. Made the connect peer dialog one field instead of separate port.

@alexfreska alexfreska merged commit 0a0bab0 into main May 17, 2024
10 checks passed
@alexfreska alexfreska deleted the fix_ipv6_connect_peer_and_block_host branch June 7, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n8maninger n8maninger n8maninger approved these changes

@ChrisSchinnerl ChrisSchinnerl Awaiting requested review from ChrisSchinnerl

Assignees

@alexfreska alexfreska

Labels
None yet
Projects
Sia
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexfreska @ChrisSchinnerl @n8maninger