Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: renterd and hostd refine config #632

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Jun 5, 2024

Set of refinements to configuration that remove confusing implicit behaviour. Now the basic/advanced toggle only affects the fields in-view, and there are separate field-specific toggles for auto calculating allowance and max collateral. Allowance and max collateral now both show in the basic view mode.

  • Basic configuration mode no longer sets certain fields in the background.
  • renterd: Allowance now has a field-specific option to auto-calculate its value.
  • hostd: Max collateral now has a field-specific option to auto-calculate its value.
  • The configuration page now has a view menu in the action bar that is consistent with all other feature pages.
  • Fixed an issue where first-time configuration would not show the optimal recommendations.
  • Fixed a bug where the churn alert would display NaN for the percentage when the total size was zero.
  • Fields now have better support and styling for readOnly.
  • Fixed an issue where toggling between basic and advanced modes would sometimes not revalidate all configuration fields.
Screenshot 2024-06-04 at 1 02 19 PM Screenshot 2024-06-04 at 1 02 12 PM Screenshot 2024-06-04 at 12 51 54 PM Screenshot 2024-06-04 at 12 51 45 PM

Copy link

changeset-bot bot commented Jun 5, 2024

🦋 Changeset detected

Latest commit: abd9e09

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
renterd Minor
@siafoundation/design-system Minor
hostd Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexfreska alexfreska force-pushed the fix_renterd_refine_recommendations branch 4 times, most recently from 62047d5 to 855ebb5 Compare June 6, 2024 13:56
Copy link
Member

@n8maninger n8maninger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed to compile.

./components/Config/ConfigStats.tsx:14:55
Type error: Property 'showAdvanced' does not exist on type '{ onSubmit: (e?: BaseSyntheticEvent<object, any, any>) => Promise; revalidateAndResetForm: () => Promise; form: UseFormReturn<{ minShards: BigNumber; ... 25 more ...; minProtocolVersion: string; }, any>; ... 14 more ...; setAutoAllowance: Dispatch<...>; }'.

12 | export function ConfigStats() {
13 |   const { autopilot } = useApp()

14 | const { estimates, redundancyMultiplier, storageTB, showAdvanced } =
| ^
15 | useConfig()
16 |
17 | const { canEstimate, estimatedSpendingPerMonth, estimatedSpendingPerTB } =
Error occurred while trying to run the build command

@alexfreska alexfreska force-pushed the fix_renterd_refine_recommendations branch from 855ebb5 to e935c2b Compare June 7, 2024 14:57
@alexfreska alexfreska force-pushed the fix_renterd_refine_recommendations branch from e935c2b to abd9e09 Compare June 7, 2024 19:29
@alexfreska alexfreska merged commit 5611d44 into main Jun 10, 2024
10 checks passed
@alexfreska alexfreska deleted the fix_renterd_refine_recommendations branch June 10, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants