Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: renterd hostd config tests #633

Merged
merged 1 commit into from
Jun 10, 2024
Merged

fix: renterd hostd config tests #633

merged 1 commit into from
Jun 10, 2024

Conversation

alexfreska
Copy link
Member

  • Test hostd config behaviours: saving, re-announce warning, basic vs advanced view, auto vs manual max collateral.
  • Test renterd config behaviours: saving, spending estimates, basic vs advanced view, auto vs manual allowance, system recommendations.
  • renterd-e2e and hostd-e2e setup, fixtures, and configuration for running against daemon.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0c4e595

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alexfreska alexfreska force-pushed the fix_renterd_hostd_config_tests branch from 1d1f056 to 5e73814 Compare June 7, 2024 15:16
n8maninger
n8maninger requested changes Jun 7, 2024
View reviewed changes
Copy link
Member

@n8maninger n8maninger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/SiaFoundation/web/actions/runs/9419304044/job/25948768960?pr=633#step:8:586

@alexfreska alexfreska force-pushed the fix_renterd_hostd_config_tests branch 3 times, most recently from e61932a to 531c452 Compare June 7, 2024 19:12
@alexfreska alexfreska force-pushed the fix_renterd_refine_recommendations branch from e935c2b to abd9e09 Compare June 7, 2024 19:29
@alexfreska alexfreska force-pushed the fix_renterd_hostd_config_tests branch 2 times, most recently from dfb04a1 to b14524a Compare June 7, 2024 19:33
Base automatically changed from fix_renterd_refine_recommendations to main June 10, 2024 13:19
@alexfreska alexfreska force-pushed the fix_renterd_hostd_config_tests branch 2 times, most recently from 8e50e00 to 756ff53 Compare June 10, 2024 18:31
@alexfreska alexfreska force-pushed the fix_renterd_hostd_config_tests branch from 756ff53 to 0c4e595 Compare June 10, 2024 19:02
@alexfreska alexfreska requested a review from n8maninger June 10, 2024 19:35
@alexfreska
Copy link
Member Author

@n8maninger I was battling with some flakiness, should be pretty stable and ✅ now.

@alexfreska alexfreska merged commit 64da64b into main Jun 10, 2024
11 checks passed
@alexfreska alexfreska deleted the fix_renterd_hostd_config_tests branch June 10, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n8maninger n8maninger n8maninger approved these changes

@ChrisSchinnerl ChrisSchinnerl Awaiting requested review from ChrisSchinnerl

Assignees
No one assigned
Labels
None yet
Projects
Sia
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexfreska @n8maninger