Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add explored-types, js, and react hooks libraries #693

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

telestrial
Copy link
Contributor

@telestrial telestrial commented Aug 20, 2024

Questions/comments:

  • Types - totally open to other ideas here. My vision is that someone using the @siafoundation/explored-types library shouldn't have to touch @siafoundation/types for anything having to do with the API.
import { Address, ExplorerTransaction, Transaction } from '@siafoundation/explored-types'
  • Base React hooks. Definitely check me here. I'm still learning these.
  • Comments. I may not have all the information to write authoritatively about this but I wanted to be sure to include as much information as I thought I knew. Let me know if anything looks off here.
  • READMEs. These expand on some of the conventions seen in other libraries following roughly the same format.
  • Would it make sense to name the typescript axios library explored-sdk?

Feel free to let it fly about anything else you see. Thanks!

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 5:38pm
explorer-zen ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 5:38pm
hostd ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 5:38pm
renterd ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 5:38pm
website ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 5:38pm

Copy link

changeset-bot bot commented Aug 20, 2024

🦋 Changeset detected

Latest commit: 1dea511

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@siafoundation/explored-js Minor
@siafoundation/explored-react Minor
@siafoundation/explored-types Minor
@siafoundation/types Minor
@siafoundation/design-system Patch
@siafoundation/hostd-types Patch
@siafoundation/renterd-types Patch
@siafoundation/sdk Patch
@siafoundation/units Patch
@siafoundation/walletd-mock Patch
@siafoundation/walletd-types Patch
@siafoundation/hostd-js Patch
@siafoundation/hostd-react Patch
@siafoundation/renterd-js Patch
@siafoundation/renterd-react Patch
@siafoundation/walletd-react Patch
@siafoundation/walletd-js Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@alexfreska alexfreska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good! Just some change requests on the documentation and code examples, otherwise lets get this merged so we can publish the libraries and test consuming them over NPM.

.changeset/spicy-cooks-buy.md Outdated Show resolved Hide resolved
libs/explored-js/README.md Outdated Show resolved Hide resolved
libs/explored-js/README.md Outdated Show resolved Hide resolved
libs/explored-js/README.md Show resolved Hide resolved
libs/explored-js/src/example.ts Outdated Show resolved Hide resolved
libs/explored-react/README.md Show resolved Hide resolved
libs/explored-react/src/hooks.ts Show resolved Hide resolved
libs/explored-types/README.md Outdated Show resolved Hide resolved
libs/explored-types/README.md Show resolved Hide resolved
libs/explored-types/src/types.ts Outdated Show resolved Hide resolved
Copy link
Member

@alexfreska alexfreska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! lets get this merged 🚀

@alexfreska alexfreska merged commit 04b45f7 into main Aug 21, 2024
16 of 17 checks passed
@alexfreska alexfreska deleted the feat_explorerd_lib branch August 21, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants