-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add explored-types, js, and react hooks libraries #693
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
🦋 Changeset detectedLatest commit: 1dea511 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good! Just some change requests on the documentation and code examples, otherwise lets get this merged so we can publish the libraries and test consuming them over NPM.
26bc4ce
to
e4d8363
Compare
e4d8363
to
1dea511
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! lets get this merged 🚀
Questions/comments:
@siafoundation/explored-types
library shouldn't have to touch@siafoundation/types
for anything having to do with the API.Feel free to let it fly about anything else you see. Thanks!