Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(renterd): min account expiry and min price table validity units #852

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Dec 12, 2024

  • The min account expiry and min price table validity configuration settings are now stored in milliseconds.

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
renterd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 4:48pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 4:48pm
explorer-zen ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 4:48pm
hostd ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 4:48pm
website ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 4:48pm

Copy link

changeset-bot bot commented Dec 12, 2024

🦋 Changeset detected

Latest commit: b62a40c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
renterd Minor
@siafoundation/units Minor
@siafoundation/clusterd Patch
@siafoundation/hostd-react Patch
@siafoundation/renterd-react Patch
@siafoundation/walletd-mock Patch
@siafoundation/walletd-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member Author

alexfreska commented Dec 12, 2024

@alexfreska alexfreska force-pushed the 12-12-refactor_renterd_min_account_expiry_and_min_price_table_validity_units branch from 2d9acb0 to 0f8b3ab Compare December 12, 2024 22:19
@alexfreska alexfreska changed the base branch from main to chore_update_cluster December 12, 2024 22:19
@alexfreska alexfreska mentioned this pull request Dec 12, 2024
@alexfreska alexfreska force-pushed the 12-12-refactor_renterd_min_account_expiry_and_min_price_table_validity_units branch 2 times, most recently from d9c5154 to 1b892c0 Compare December 12, 2024 22:24
Copy link
Member

@peterjan peterjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast turnaround on all these issues! Making me look bad 😁

@alexfreska alexfreska force-pushed the 12-12-refactor_renterd_min_account_expiry_and_min_price_table_validity_units branch from 1b892c0 to 06dc7dc Compare December 13, 2024 15:16
Copy link
Member Author

Single test failing due to SiaFoundation/renterd#1747

Copy link
Member Author

alexfreska commented Dec 13, 2024

Merge activity

  • Dec 13, 11:43 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 13, 11:46 AM EST: Graphite rebased this pull request as part of a merge.
  • Dec 13, 11:47 AM EST: A user merged this pull request with Graphite.

@alexfreska alexfreska changed the base branch from chore_update_cluster to graphite-base/852 December 13, 2024 16:43
@alexfreska alexfreska changed the base branch from graphite-base/852 to main December 13, 2024 16:44
@alexfreska alexfreska force-pushed the 12-12-refactor_renterd_min_account_expiry_and_min_price_table_validity_units branch from 06dc7dc to b62a40c Compare December 13, 2024 16:45
@alexfreska alexfreska merged commit b04c20e into main Dec 13, 2024
12 of 33 checks passed
@alexfreska alexfreska deleted the 12-12-refactor_renterd_min_account_expiry_and_min_price_table_validity_units branch December 13, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants