Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explored-types): use core Event and return arrays on address routes #884

Conversation

telestrial
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 9:59pm
explorer-zen ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 9:59pm
hostd ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 9:59pm
renterd ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 9:59pm
website ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 9:59pm

Copy link

changeset-bot bot commented Jan 13, 2025

🦋 Changeset detected

Latest commit: 23d3dc6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@siafoundation/explored-types Minor
@siafoundation/explored-js Patch
@siafoundation/explored-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

telestrial commented Jan 13, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@@ -8,6 +8,7 @@ import {
ConsensusNetwork,
ConsensusState,
Currency,
Event,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be ExplorerEvent if its not the Event from our core types package?

@telestrial telestrial force-pushed the 01-13-refactor_explored-types_modify_event_type_to_match_explored_implementation branch from 1fd45e6 to 2522241 Compare January 14, 2025 19:08
@telestrial telestrial closed this Jan 14, 2025
@telestrial telestrial deleted the 01-13-fix_explored-types_use_core_event_and_return_arrays_on_address_routes branch January 14, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants