Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hostd): volume delete fixture #912

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Feb 3, 2025

  • Volume removal now takes longer so tests can no rely on the presence of the volume row to verify removal since it can take longer than the test timeout for the row to disappear. Instead we now verify removal by only checking the status has changed to removing.

Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 3:04pm
explorer-zen ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 3:04pm
hostd ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 3:04pm
renterd ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 3:04pm
website ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 3:04pm

Copy link

changeset-bot bot commented Feb 3, 2025

⚠️ No Changeset found

Latest commit: ba9bca7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alexfreska alexfreska force-pushed the fix_hostd_volume_delete_test branch from 431fae9 to 33f8856 Compare February 4, 2025 14:48
Copy link
Member Author

alexfreska commented Feb 4, 2025

Merge activity

  • Feb 4, 10:03 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Feb 4, 10:04 AM EST: Graphite rebased this pull request as part of a merge.
  • Feb 4, 10:05 AM EST: A user merged this pull request with Graphite.

@alexfreska alexfreska force-pushed the fix_hostd_volume_delete_test branch from 33f8856 to ba9bca7 Compare February 4, 2025 15:04
@alexfreska alexfreska merged commit 45ac182 into main Feb 4, 2025
12 of 33 checks passed
@alexfreska alexfreska deleted the fix_hostd_volume_delete_test branch February 4, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants