Proposal for fieldref wildcard support #305
Merged
+39
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Field references can currently only specify a full match on two fields, but for backends that support it, we have found that in practice being able to partially match one field against another is important. This commit introduces the ability for a field reference to have a leading or trailing wildcard and updates the
contains
,startswith
, andendswith
modifiers to allow the rule to set them.Note: the current design assumes that the modifiers will be applied with the
fieldref
first, then the relevant wildcard modifier. Changing this order would require being able to extract the leading/trailing wildcards from the SigmaString - which is doable, but would require some additional logic to achieve.