Open
Conversation
To enhance your password tool, I focused on accessibility, user experience (UX), and semantic structure. I made it more accessible by explicitly linking all <label>s to their inputs (like the slider and checkboxes) using for/id, replacing the div-based strength bars with the proper <meter> tag, and adding aria-live so screen readers announce dynamic updates like "Copied!" or the new strength level. For better UX, I changed the checker input to type="password" to mask typing and added a "Show Password" toggle. Finally, I improved the HTML structure by wrapping the generator and checker controls in separate <form> tags and grouping the checkboxes with a <fieldset>, making the tool more robust and easier for all users to navigate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To enhance your password tool, I focused on accessibility, user experience (UX), and semantic structure. I made it more accessible by explicitly linking all s to their inputs (like the slider and checkboxes) using for/id, replacing the div-based strength bars with the proper tag, and adding aria-live so screen readers announce dynamic updates like "Copied!" or the new strength level. For better UX, I changed the checker input to type="password" to mask typing and added a "Show Password" toggle. Finally, I improved the HTML structure by wrapping the generator and checker controls in separate
tags and grouping the checkboxes with a , making the tool more robust and easier for all users to navigate.