Fix validation for DRGElements (dmn-tck#632)

SimonRinguette · Feb 15, 2024 · 629c692 · 629c692
1 parent 1d0c4ae
commit 629c692
Showing 1 changed file with 1 addition and 15 deletions.
diff --git a/runners/dmn-tck-validation/src/test/java/org/omg/dmn/tck/validation/TestCasesFiles.java b/runners/dmn-tck-validation/src/test/java/org/omg/dmn/tck/validation/TestCasesFiles.java
@@ -206,7 +206,7 @@ private void checkInputDataHasTypeRef(File dmnFile) throws Exception {
         }
     }
 
-    // DRGElement.name == DRGElement.variable.name and DRGElement.typeRef == DRGElement.variable.typeRef
+    // DRGElement.name == DRGElement.variable.name
     private void checkDRGElementVariable(File dmnFile) throws Exception {
         Document xmlDocument = builder.parse(dmnFile);
         List<String> problems = new ArrayList<>();
@@ -228,10 +228,8 @@ private List<String> checkDRGElementVariable(File dmnFile, Document xmlDocument,
                 Node drgElementNode = xPathVariables.item(i);
                 // Extract and compare values
                 String name = extractStringAttribute(drgElementNode, "name");
-                String typeRef = extractStringAttribute(drgElementNode, "typeRef");
                 Node variableNode = extractChild(drgElementNode, "variable");
                 String variableName = extractStringAttribute(variableNode, "name");
-                String variableTypeRef = extractStringAttribute(variableNode, "typeRef");
                 // Check name
                 if (name != null && variableName != null) {
                     if (!name.equals(variableName)) {
@@ -244,18 +242,6 @@ private List<String> checkDRGElementVariable(File dmnFile, Document xmlDocument,
                         problems.add(problem);
                     }
                 }
-                // Check typeRef
-                if (typeRef != null && variableTypeRef != null) {
-                    if (!typeRef.equals(variableTypeRef)) {
-                        String problem = String.format("%s: DRGElement node %s typeRef '%s' is the same with the variable typeRef '%s'",
-                                dmnFile.getName(),
-                                elementName,
-                                name,
-                                variableName);
-                        System.err.println(problem);
-                        problems.add(problem);
-                    }
-                }
             }
         }
         return problems;