Remove "other_middlewares" configuration

SimpleBus · Jan 11, 2019 · 939594a · 939594a
1 parent 5bfc819
commit 939594a
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 9 deletions.
diff --git a/src/DependencyInjection/CommandBusConfiguration.php b/src/DependencyInjection/CommandBusConfiguration.php
@@ -31,7 +31,6 @@ public function getConfigTreeBuilder()
                     ->children()
                         ->booleanNode('logger')->defaultFalse()->end()
                         ->booleanNode('finishes_command_before_handling_next')->defaultTrue()->end()
-                        ->booleanNode('other_middlewares')->defaultTrue()->end()
                     ->end()
                 ->end()
                 ->arrayNode('logging')

diff --git a/src/DependencyInjection/CommandBusExtension.php b/src/DependencyInjection/CommandBusExtension.php
@@ -57,7 +57,5 @@ protected function loadInternal(array $mergedConfig, ContainerBuilder $container
             $container->getDefinition('simple_bus.command_bus.finishes_command_before_handling_next_middleware')
                 ->addTag('command_bus_middleware', ['priority' => 1000]);
         }
-
-        $container->setParameter('simple_bus.command_bus.append_tagged_middlewares', $mergedConfig['middlewares']['other_middlewares']);
     }
 }
diff --git a/src/DependencyInjection/Compiler/ConfigureMiddlewares.php b/src/DependencyInjection/Compiler/ConfigureMiddlewares.php
@@ -26,11 +26,6 @@ public function process(ContainerBuilder $container)
             return;
         }
 
-        if (!$container->hasParameter('simple_bus.command_bus.append_tagged_middlewares')
-            || !$container->getParameter('simple_bus.command_bus.append_tagged_middlewares')) {
-            return;
-        }
-
         $middlewareIds = new \SplPriorityQueue();
 
         foreach ($container->findTaggedServiceIds($this->busTag) as $specializedBusId => $tags) {

diff --git a/tests/SymfonyBundle/DependencyInjection/Compiler/ConfigureMiddlewaresTest.php b/tests/SymfonyBundle/DependencyInjection/Compiler/ConfigureMiddlewaresTest.php
@@ -34,7 +34,6 @@ protected function setUp()
         $this->mainBusDefinition->setPublic(true);
         $this->container->setDefinition($this->mainBusId, $this->mainBusDefinition);
         $this->container->addCompilerPass(new ConfigureMiddlewares($this->mainBusId, $this->middlewareTag));
-        $this->container->setParameter('simple_bus.command_bus.append_tagged_middlewares', true);
     }
 
     /**