Skip to content

Comments

fixed deepgram worker script run#212

Merged
AnkushMalaker merged 1 commit intoSimpleOpenSoftware:mainfrom
Ushadow-io:FIX/deepgram-workers
Dec 18, 2025
Merged

fixed deepgram worker script run#212
AnkushMalaker merged 1 commit intoSimpleOpenSoftware:mainfrom
Ushadow-io:FIX/deepgram-workers

Conversation

@thestumonkey
Copy link
Contributor

@thestumonkey thestumonkey commented Dec 18, 2025

start-workers.sh was exiting if parakeet env was not set

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced backend worker initialization to ensure graceful operation when optional worker processes are unavailable, improving overall system stability and robustness.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 18, 2025

Walkthrough

Modifies a shell script to append || true to two conditional echo statements for Deepgram and Parakeet stream workers, preventing script termination under set -e when those optional workers are not started.

Changes

Cohort / File(s) Summary
Shell script safety fix
backends/advanced/start-workers.sh
Appends || true to optional Deepgram and Parakeet worker echo statements to prevent script exit when worker startup conditions fail under set -e

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Simple, repetitive pattern change (adding error suppression to two lines)
  • No logic changes or functional impact

Possibly related PRs

  • chronicler-ai/chronicle#199 — Also modifies backends/advanced/start-workers.sh and handles Deepgram/Parakeet worker startup/shutdown logic

Suggested reviewers

  • 0xrushi

Poem

🐰 A script that stumbled when workers were shy,
Now wrapped in || true, it won't say goodbye!
Two echo lines safe from the set -e embrace—
Safe workers for all in this debugging space! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fixed deepgram worker script run' is partially related to the changeset. It mentions deepgram, but the actual changes address both Deepgram and Parakeet worker scripts, with the primary fix being to prevent script exit when optional workers are not started. Consider using a more comprehensive title like 'Fix worker script exit on missing optional environment variables' to better reflect that both Deepgram and Parakeet are affected and the core issue is about handling missing optional workers.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 81297d7 and 1afc979.

📒 Files selected for processing (1)
  • backends/advanced/start-workers.sh (1 hunks)
🔇 Additional comments (1)
backends/advanced/start-workers.sh (1)

83-84: LGTM! The fix correctly prevents script exit under set -e.

The addition of || true ensures these conditional echo statements don't cause the script to exit when the optional worker PIDs are empty. Since set -e is enabled (line 5), a failed test like [ -n "$AUDIO_STREAM_DEEPGRAM_WORKER_PID" ] would normally terminate the script. The || true suffix guarantees a successful exit code regardless of whether the workers were started.

This pattern is consistent with similar conditional logic elsewhere in the script (lines 125-126, 151-152, 185-186).


Comment @coderabbitai help to get the list of available commands and usage tips.

@AnkushMalaker AnkushMalaker merged commit 2443ad1 into SimpleOpenSoftware:main Dec 18, 2025
2 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants