Invert if for uhhh yeah

Simyon264 · May 23, 2024 · 0d5ab9f · 0d5ab9f
1 parent 421edbe
commit 0d5ab9f
Showing 1 changed file with 27 additions and 27 deletions.
diff --git a/ReplayBrowser/Helpers/Ss14ApiHelper.cs b/ReplayBrowser/Helpers/Ss14ApiHelper.cs
@@ -16,40 +16,40 @@ public Ss14ApiHelper(IMemoryCache cache)
 
     public async Task<PlayerData?> FetchPlayerDataFromGuid(Guid guid)
     {
-        if (!_cache.TryGetValue(guid.ToString(), out PlayerData? playerKey))
+        if (_cache.TryGetValue(guid.ToString(), out PlayerData? playerKey))
+            return playerKey;
+
+        playerKey = new PlayerData()
         {
-            playerKey = new PlayerData()
-            {
-                PlayerGuid = guid
-            };
+            PlayerGuid = guid
+        };
 
-            HttpResponseMessage response = null;
-            try
+        HttpResponseMessage response = null;
+        try
+        {
+            var httpClient = new HttpClient();
+            response = await httpClient.GetAsync($"https://central.spacestation14.io/auth/api/query/userid?userid={playerKey.PlayerGuid}");
+            response.EnsureSuccessStatusCode();
+            var responseString = await response.Content.ReadAsStringAsync();
+            var username = JsonSerializer.Deserialize<UsernameResponse>(responseString).userName;
+            playerKey.Username = username;
+        }
+        catch (Exception e)
+        {
+            Log.Error("Unable to fetch username for player with GUID {PlayerGuid}: {Error}", playerKey.PlayerGuid, e.Message);
+            if (e.Message.Contains("'<' is an")) // This is a hacky way to check if we got sent a website.
             {
-                var httpClient = new HttpClient();
-                response = await httpClient.GetAsync($"https://central.spacestation14.io/auth/api/query/userid?userid={playerKey.PlayerGuid}");
-                response.EnsureSuccessStatusCode();
-                var responseString = await response.Content.ReadAsStringAsync();
-                var username = JsonSerializer.Deserialize<UsernameResponse>(responseString).userName;
-                playerKey.Username = username;
+                // Probably got sent a website? Log full response.
+                Log.Error("Website might have been sent: {Response}", response?.Content.ReadAsStringAsync().Result);
             }
-            catch (Exception e)
-            {
-                Log.Error("Unable to fetch username for player with GUID {PlayerGuid}: {Error}", playerKey.PlayerGuid, e.Message);
-                if (e.Message.Contains("'<' is an")) // This is a hacky way to check if we got sent a website.
-                {
-                    // Probably got sent a website? Log full response.
-                    Log.Error("Website might have been sent: {Response}", response?.Content.ReadAsStringAsync().Result);
-                }
 
-                playerKey.Username = "Unable to fetch username (API error)";
-            }
+            playerKey.Username = "Unable to fetch username (API error)";
+        }
 
-            var cacheEntryOptions = new MemoryCacheEntryOptions()
-                .SetAbsoluteExpiration(TimeSpan.FromMinutes(60));
+        var cacheEntryOptions = new MemoryCacheEntryOptions()
+            .SetAbsoluteExpiration(TimeSpan.FromMinutes(60));
 
-            _cache.Set(guid.ToString(), playerKey, cacheEntryOptions);
-        }
+        _cache.Set(guid.ToString(), playerKey, cacheEntryOptions);
 
         return playerKey;
     }