Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributors Page that auto-fills using GitHub API #26

Merged
merged 7 commits into from
Aug 21, 2024
Merged

Contributors Page that auto-fills using GitHub API #26

merged 7 commits into from
Aug 21, 2024

Conversation

bhenrich
Copy link
Contributor

@bhenrich bhenrich commented Aug 21, 2024 •
edited
Loading

Contributors Page

Goals of this PR:

  • Avoid confusion on who started this project (exhibit a: liltenhead's video)
  • Create a simple solution that requires minimal maintenance and is easily re-designable

To-Do

  • Create the /contributors page and route it
  • Helper Class that fetches contribs from the GitHub API
  • Automatically populate the /contributors page on load
  • (?) Sort contribs by commits / lines / just alphabetically doesnt make sense

Closes #24

@bhenrich bhenrich marked this pull request as ready for review August 21, 2024 10:49
Simyon264
Simyon264 requested changes Aug 21, 2024
View reviewed changes
Copy link
Owner

@Simyon264 Simyon264 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, it's looking pretty good.

ReplayBrowser/appsettings.json Show resolved Hide resolved
ReplayBrowser/Pages/Shared/ContributorCard.razor Outdated Show resolved Hide resolved
ReplayBrowser/Helpers/GitHubApiHelper.cs Outdated Show resolved Hide resolved
ReplayBrowser/Pages/Contributors.razor Outdated Show resolved Hide resolved
ReplayBrowser/Pages/Contributors.razor Outdated Show resolved Hide resolved
ReplayBrowser/Helpers/GitHubApiHelper.cs Outdated Show resolved Hide resolved
ReplayBrowser/Helpers/GitHubApiHelper.cs Outdated Show resolved Hide resolved
@bhenrich bhenrich requested a review from Simyon264 August 21, 2024 12:02
Simyon264
Simyon264 requested changes Aug 21, 2024
View reviewed changes
ReplayBrowser/Startup.cs Outdated Show resolved Hide resolved
@bhenrich bhenrich requested a review from Simyon264 August 21, 2024 12:07
Simyon264
Simyon264 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Owner

@Simyon264 Simyon264 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Simyon264
Copy link
Owner

mrow

@Simyon264 Simyon264 merged commit 70424f1 into Simyon264:master Aug 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simyon264 Simyon264 Simyon264 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dedicated contributors page
2 participants
@bhenrich @Simyon264