Search de-base64ed #74
Conversation
Also 1984 out user facing distinction between user redacted, admin redacted and GDPR request redacted accounts
| @@ -14,6 +14,8 @@ namespace ReplayBrowser.Helpers; | |||
|
|
|||
| public class ReplayHelper | |||
| { | |||
| static readonly string REDACTION_MESSAGE = "The account you are trying to search for is private or deleted. This might happen for various reasons as chosen by the account owner or the site administrative decision"; | |||
| return; | ||
|
|
||
| // Is there any redaction to worry about? | ||
| if (!found.Settings.RedactInformation && !found.Protected) |
There was a problem hiding this comment.
Protected accounts can still change their redaction settings and the only thing .Protected does is display a message on the home page. This should not be checked for redaction status.
There was a problem hiding this comment.
BTW does that keep showing up even when redaction is on?
Also need to eventually clarify in UI and code as to which combo deletes stuff and which just hides it from public view.
There was a problem hiding this comment.
Yeah. It will keep showing up, even if your settings are changed. Only way to remove it is to edit the DB.
ReplayBrowser/Pages/Search.razor
Outdated
| @@ -245,6 +236,7 @@ | |||
| NavigationManager.NavigateTo("/"); | |||
There was a problem hiding this comment.
(UNRELATED, but also should probably remove this line as well, idk why its there)
|
|
||
| <div class="search-bar"> | ||
| @{ | ||
| RenderLine(null); |
There was a problem hiding this comment.
Could probably leave a comment here for future devs that this is meant to draw the prefab. Was a bit confused at first :p
|
From my testing, it all works still. |
Mmm base64-less chicken. Er, query.
Please test it for not breaking anything