Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade next from 13.1.2 to 14.2.7 #129

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sumansaurabh
Copy link

@sumansaurabh sumansaurabh commented Oct 16, 2024

User description

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • apps/file-q-and-a/nextjs-with-flask-server/client/package.json
    • apps/file-q-and-a/nextjs-with-flask-server/client/package-lock.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
high severity 696/1000
Why? Recently disclosed, Has a fix available, CVSS 8.2
Uncontrolled Recursion
SNYK-JS-NEXT-8186172
Yes No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: next The new version differs by 250 commits.
  • a1c3a03 v14.2.7
  • d46ab2c Fix hmr assetPrefix escaping and reuse logic from other files (#67983)
  • d11cbc9 Reject next image urls in image optimizer (#68628)
  • 575385e Fix bad modRequest in flight entry manifest (#68888)
  • 9ecf2e8 update turbopack build manifest
  • 325dc4b pages router: ensure x-middleware-cache is respected (#67734)
  • d3021b6 update playwright interface
  • 5e6f511 fix i18n data pathname resolving (#68947)
  • dd32e0f Update font data (#68639)
  • 2f7fa98 Add deployment id header for rsc payload if present (#67255)
  • 545746e fix: properly patch lockfile against swc bindings (#66515)
  • 26c80ee GTM dataLayer parameter should take an object, not an array of strings (#66339)
  • bce2ec0 build: upgrade edge-runtime (#67565)
  • 96d6ada fix(next): add cross origin in react dom preload (#67423)
  • c572030 fix: Narrow down from `string | undefined` to `string` (#65248)
  • b5db704 Refactor internal routing headers to use request meta (#66987)
  • deeeb5f Revert "chore: externalize undici for bundling" (#65727)
  • 43f24d0 Switch from automatically requesting reviews to manually requesting them (#67024)
  • 42f0129 fix formatting from #69164
  • 427c01d v14.2.6
  • d4ca0b9 Ensure fetch cache TTL is updated properly (#69164)
  • eee87cb remove invalid line in disabling webpack cache example
  • dc40cc9 Fix typo in memory usage docs
  • 28110b6 [docs] Backport Multi-Zones docs to 14.x branch (#68460)

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.


Description

This PR upgrades the next dependency and related packages to address security vulnerabilities:

  • Upgraded next from version 13.1.2 to 14.2.7.
  • Updated package-lock.json to reflect the new versions of dependencies.
  • This change resolves vulnerabilities identified by Snyk.

Changes walkthrough 📝

Relevant files
Enhancement
package.json
Upgrade `next` dependency to version 14.2.7                           

apps/file-q-and-a/nextjs-with-flask-server/client/package.json

  • Updated next dependency from version 13.1.2 to 14.2.7.
+1/-1     
package-lock.json
Update package-lock.json for dependency upgrades                 

apps/file-q-and-a/nextjs-with-flask-server/client/package-lock.json

  • Upgraded next and related dependencies to version 14.2.7.
  • Updated various other dependencies to their latest versions.
  • +212/-260

    💡 Penify usage:
    Comment /help on the PR to get a list of all available Penify tools and their descriptions

    … apps/file-q-and-a/nextjs-with-flask-server/client/package-lock.json to reduce vulnerabilities
    
    The following vulnerabilities are fixed with an upgrade:
    - https://snyk.io/vuln/SNYK-JS-NEXT-8186172
    @penify-dev penify-dev bot added enhancement New feature or request Review effort [1-5]: 2 labels Oct 16, 2024
    Copy link

    penify-dev bot commented Oct 16, 2024

    PR Review 🔍

    ⏱️ Estimated effort to review [1-5]

    2, because the changes are primarily version upgrades in package.json and package-lock.json, which are straightforward to review.

    🧪 Relevant tests

    No

    ⚡ Possible issues

    Possible Breaking Change: The upgrade from Next.js 13.1.2 to 14.2.7 may introduce breaking changes. Ensure to check the Next.js migration guide for any necessary adjustments in the codebase.

    🔒 Security concerns

    No

    Copy link

    penify-dev bot commented Oct 16, 2024

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Testing
    Run tests to confirm application stability after the upgrade

    It is advisable to run tests after upgrading next to ensure that the application functions
    as expected with the new version.

    apps/file-q-and-a/nextjs-with-flask-server/client/package.json [30]

    -"next": "14.2.7",
    +"next": "14.2.7", // Run tests post-upgrade
     
    Suggestion importance[1-10]: 8

    Why: Running tests post-upgrade is crucial for confirming application stability, making this a significant suggestion.

    8
    Compatibility
    Verify compatibility of the upgraded package with existing dependencies

    Consider checking the compatibility of the new version of next (14.2.7) with other
    dependencies in your project, as major upgrades can introduce breaking changes.

    apps/file-q-and-a/nextjs-with-flask-server/client/package.json [30]

    -"next": "14.2.7",
    +"next": "14.2.7", // Ensure compatibility with other dependencies
     
    Suggestion importance[1-10]: 7

    Why: This suggestion emphasizes the importance of ensuring compatibility with other dependencies, which is relevant after a major version upgrade.

    7
    Verify Node.js version compatibility with the upgraded package

    Ensure that the version of next specified is compatible with the Node.js version used in
    your environment to avoid runtime issues.

    apps/file-q-and-a/nextjs-with-flask-server/client/package.json [30]

    -"next": "14.2.7",
    +"next": "14.2.7", // Check Node.js version compatibility
     
    Suggestion importance[1-10]: 6

    Why: While checking Node.js compatibility is important, it is a more general practice and less urgent compared to testing the application after an upgrade.

    6
    Documentation
    Check the release notes for important changes in the new version

    Review the release notes for next version 14.2.7 to understand new features and deprecated
    functionalities that may affect your application.

    apps/file-q-and-a/nextjs-with-flask-server/client/package.json [30]

    -"next": "14.2.7",
    +"next": "14.2.7", // Review release notes for changes
     
    Suggestion importance[1-10]: 7

    Why: Understanding new features and deprecated functionalities is important for maintaining the application, though it is slightly less critical than running tests.

    7

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants