Skip to content

Conversation

@stefannikolei
Copy link
Contributor

No description provided.

@JimBobSquarePants
Copy link
Member

We'll need to fix the build on main first (by copying some build config from ImageSharp)

@stefannikolei
Copy link
Contributor Author

We'll need to fix the build on main first (by copying some build config from ImageSharp)

And this project was still on net6

* removed the configure method. thats only syntactic sugar and aot is not happy with that method
@stefannikolei
Copy link
Contributor Author

I have updated this lib to .net8 and .net9. I had to fix some issues which were reported.

The configure method was complaining multiple things because of aot. Because this is just a lil bit of syntactic sugar i went with deleting it

@codecov
Copy link

codecov bot commented Jul 12, 2025

Codecov Report

❌ Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86%. Comparing base (7ecd732) to head (d9a35b7).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...Sharp.Web/Commands/QueryCollectionRequestParser.cs 50% 1 Missing ⚠️
...rc/ImageSharp.Web/Processors/ResizeWebProcessor.cs 0% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@         Coverage Diff         @@
##           main   #387   +/-   ##
===================================
  Coverage    85%    86%           
===================================
  Files        82     83    +1     
  Lines      2361   2397   +36     
  Branches    356    365    +9     
===================================
+ Hits       2023   2063   +40     
+ Misses      232    224    -8     
- Partials    106    110    +4     
Flag Coverage Δ
unittests 86% <94%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JimBobSquarePants
Copy link
Member

@stefannikolei I need to have a good look at this as I'm not happy with all the new required attributes. Will try my best to get on it soon.

@stefannikolei
Copy link
Contributor Author

@stefannikolei I need to have a good look at this as I'm not happy with all the new required attributes. Will try my best to get on it soon.

I was not happy about that dynamicaccessedattributes either.

Those are probably from enabled aot.

We could also go the way of removing them and add istrimmable = false.

@stefannikolei
Copy link
Contributor Author

I updated this branch.

It's still to be discussed wether to disable trimming support or keep the added attributes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants