Skip to content

Backport #2701 to 2.1.x #2868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Visual-Vincent
Copy link

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Backport of #2701 for v2.1.x. Fixes #2638.

@CLAassistant
Copy link

CLAassistant commented Jan 24, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@JimBobSquarePants
Copy link
Member

We'll need to update the build script to pass the correct MinVer configuration in order to get this building according to the error here.

https://github.com/SixLabors/ImageSharp/actions/runs/13079652697/job/36600666070?pr=2868#step:10:109

@JimBobSquarePants
Copy link
Member

@Visual-Vincent are you able to update your fork using the latest release/v2.1.x branch. We've added fixes for the build process there.

@antonfirsov antonfirsov mentioned this pull request Feb 24, 2025
4 tasks
@antonfirsov
Copy link
Member

Somehow I don't have the rights to push to @Visual-Vincent's branch, closing in favor of #2891.

@antonfirsov antonfirsov mentioned this pull request Feb 24, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants