Fix/Community-auth-fixes-frontend by udulaThathsaridu · Pull Request #1070 · SkappHQ/skapp

udulaThathsaridu · 2026-02-17T10:13:25Z

PR checklist

TaskId: (https://rootcode.skapp.com/pm/projects/SKAPP/items/1381)

Summary

-Community Code auth fixes for frontend

How to test

Project Checklist

Other

New atomic components added
New molecules added
New pages(routes) added
New dependencies installed

PR Checklist

Pull request is raised from the correct source branch
Pull request is raised to the correct destination branch
Pull request is raised with correct title
Pull request is self reviewed
Pull request is self assigned
Suitable pull request status labels are added (ready-for-code-review)

Additional Information

…mpany objectives

…o latest commit

…commit

Fix/merge conflict

Pm release 5

# Conflicts: # backend/src/main/java/com/skapp/community/peopleplanner/service/impl/RolesServiceImpl.java

…ctives Feat/636 company objectives

Develop improvements

Update README.md

Develop

CLAassistant · 2026-02-17T10:13:41Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Copilot

Pull request overview

This PR implements authentication fixes for the community edition of the application. It separates community authentication logic from enterprise features by introducing fallback implementations for enterprise-specific functionality and implementing credential-based sign-in/sign-up for the community edition.

Changes:

Added fallback implementations for enterprise features (auth utilities, enums, API endpoints, calendar hooks, and APICTA dashboard)
Implemented community-specific sign-in and sign-up functions with proper API endpoints
Updated authentication flow to conditionally add tenant headers only in enterprise mode
Fixed sign-in/sign-up status checks to properly access the status property from the response object

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
frontend/src/fallback/common/utils/commonUtil.ts	Adds fallback stubs for enterprise utility functions
frontend/src/fallback/common/enums/Common.ts	Provides empty enum stubs for enterprise-specific enums
frontend/src/fallback/common/api/utils/ApiEndpoints.ts	Adds empty authentication endpoints object for fallback
frontend/src/fallback/common/api/CalendarApi.ts	Implements fallback calendar organization status hook
frontend/src/fallback/auth/utils/authUtils.ts	Provides stub implementations for enterprise auth functions that always return failure
frontend/src/fallback/APICTA/dashboard.tsx	Creates empty APICTA dashboard component for fallback
frontend/src/community/common/utils/commonUtil.ts	Adds utility to check if running in enterprise mode
frontend/src/community/common/api/utils/ApiEndpoints.ts	Adds new credential-based sign-in/sign-up API endpoints
frontend/src/community/auth/utils/authUtils.ts	Implements community sign-in/sign-up functions with proper API integration
frontend/src/community/auth/utils/authInterceptor.ts	Conditionally adds tenant header only in enterprise mode
frontend/src/community/auth/types/auth.ts	Defines community-specific sign-in/sign-up parameter types
frontend/pages/index.tsx	Reorders imports (no functional change)
frontend/pages/community/signup.tsx	Fixes status check to access status property from result object
frontend/pages/community/signin.tsx	Fixes status check to access status property from result object
frontend/middleware.ts	Removes community routes from middleware matcher to allow public access to auth pages

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-17T10:18:04Z

frontend/src/community/auth/utils/authUtils.ts

+  } catch (error: any) {
+    return {
+      status: SignInStatus.FAILURE,
+      error: error?.response?.data?.[0]?.messageKey
+    };


The error handling assumes a specific error response structure error?.response?.data?.[0]?.messageKey, but if the API returns errors in a different format, the messageKey might be undefined. Consider adding a fallback error message or validating the error structure more robustly to prevent returning undefined as the error message.

same as enterprise

Copilot · 2026-02-17T10:18:04Z

frontend/src/fallback/common/utils/commonUtil.ts

  return false;
 };
+
+export const tempShouldUseCustomDashboard = () => {


The function signature of tempShouldUseCustomDashboard is inconsistent with its usage. In frontend/pages/community/dashboard/index.tsx line 159, this function is called with a parameter user?.tenantId, but the function doesn't accept any parameters. The function signature should match the expected usage: tempShouldUseCustomDashboard = (tenantId?: string | number) => boolean

Suggested change

export const tempShouldUseCustomDashboard = () => {

export const tempShouldUseCustomDashboard = (tenantId?: string | number): boolean => {

not needed since is a fallback file

Copilot · 2026-02-17T10:18:05Z

frontend/middleware.ts

  matcher: [
-    // All community routes
-    "/community/:path*",
    // Super admin routes
    "/setup-organization/:path*",
    "/module-selection",


The removal of the community routes matcher "/community/:path*" from the middleware configuration means that pages under /community/signin and /community/signup will no longer be protected by the middleware. This could be intentional to allow public access to these auth pages, but it's a significant change. If this is intentional, ensure that these pages don't contain any logic that requires middleware protection. If unintentional, this could be a security issue.

it was done to allow sign in and sign up to not be protected

Copilot · 2026-02-17T10:18:05Z

frontend/src/community/auth/utils/authUtils.ts

+  } catch (error: any) {
+    return {
+      status: SignInStatus.FAILURE,
+      error: error?.response?.data?.[0]?.messageKey
+    };


The error handling assumes a specific error response structure error?.response?.data?.[0]?.messageKey, but if the API returns errors in a different format, the messageKey might be undefined. Consider adding a fallback error message or validating the error structure more robustly to prevent returning undefined as the error message.

same as enterprise

ThinuwanW · 2026-02-18T06:36:34Z

frontend/src/community/auth/types/auth.ts

-}
+}
+export interface CommunitySignInParams {
+  email?: string;


remove option

same as enterprise

ThinuwanW · 2026-02-18T06:36:42Z

frontend/src/community/auth/types/auth.ts

+export interface CommunitySignUpParams {
+  firstName?: string;
+  lastName?: string;
+  email?: string;


remove option for required fields

same as enterprise

ThinuwanW · 2026-02-18T06:38:38Z

frontend/src/community/common/api/utils/ApiEndpoints.ts

 export const authenticationEndpoints = {
  CREATE_SUPER_ADMIN: `${moduleAPIPath.AUTH}/signup/super-admin`,
  SIGN_IN: `${moduleAPIPath.AUTH}/sign-in`,
+  CREDENTIAL_SIGN_IN: `${ApiVersions.V1}/auth/session/sign-in`,


remove the old end points

remove from BE as well

the end points

ThinuwanW · 2026-02-18T06:40:32Z

frontend/src/community/common/api/utils/ApiEndpoints.ts

@@ -12,6 +15,8 @@ export const organizationCreateEndpoints = {
 export const authenticationEndpoints = {
  CREATE_SUPER_ADMIN: `${moduleAPIPath.AUTH}/signup/super-admin`,


check in mobile if not using remove from backend

we need sign in but create SUPER admin is not needed

and its already deleted in backend

ThinuwanW · 2026-02-18T06:42:14Z

frontend/src/fallback/APICTA/dashboard.tsx

@@ -0,0 +1,5 @@
+const APICTADashboard = () => {


branch out for future reference and remove all APICTA UIs
remove all the related utils as well

ThinuwanW · 2026-02-18T06:45:25Z

frontend/src/fallback/auth/utils/authUtils.ts

@@ -0,0 +1,29 @@
+import { SignInStatus } from "~community/auth/enums/auth";


we believe the file can make empty
enterpriseSignIn , enterpriseSignUp only needed with empty body

frontend/middleware.ts

sonarqubecloud · 2026-02-19T03:38:38Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ThinuwanW · 2026-02-19T05:04:20Z

frontend/middleware.ts

  matcher: [
-    // All community routes
-    "/community/:path*",
+    // All community routes (excluding public auth pages)


lets check what is the rootcause

BojithaPiyathilake and others added 24 commits August 25, 2025 20:54

feat: Creating initial tables, classes and api endpoints to create co…

41043b7

…mpany objectives

feat: Formatting

98170f0

feat: Endpoints for retrieve and update company objectives

b9989cc

feat: Review comments addressed

2a6bdc2

feat: Formating

44f57e8

feat: Addressing comments

74519ea

feat: formatting issue

091b75e

chore: update submodule(backend/src/main/java/com/skapp/enterprise) t…

b0c2e83

…o latest commit

Merge master

91a6bd0

chore: update submodule(backend/src/main/java/com/skapp/enterprise) t…

c3f4363

…o latest commit

chore: update submodule(backend/src/main/resources/config) to latest …

eb605b4

…commit

Merge remote-tracking branch 'origin/main' into fix/merge-conflict

7afb844

Merge pull request #912 from SkappHQ/fix/merge-conflict

193f319

Fix/merge conflict

Merge pull request #911 from SkappHQ/pm-release-5

32a6d89

Pm release 5

Merge branch 'main' into feat/636-company-objectives

06ddc98

# Conflicts: # backend/src/main/java/com/skapp/community/peopleplanner/service/impl/RolesServiceImpl.java

feat: Addressing comment

4de22c1

Merge pull request #829 from BojithaPiyathilake/feat/636-company-obje…

188bd3f

…ctives Feat/636 company objectives

Merge pull request #924 from SkappHQ/develop-improvements

28c6aca

Develop improvements

Merge pull request #1022 from SkappHQ/develop-improvements

9bb64f9

Develop improvements

Update README.md

531d949

Update without underlines README.md

6435610

Merge pull request #1050 from SkappHQ/adeepabandara-skapp-patch-1

f45dfd4

Update README.md

Merge pull request #1056 from SkappHQ/develop

2ebd641

Develop

Fix/Community-auth-fixes-frontend

b78b8d7

udulaThathsaridu requested a review from hasalarootcode February 17, 2026 10:13

udulaThathsaridu self-assigned this Feb 17, 2026

udulaThathsaridu requested a review from ThinuwanW as a code owner February 17, 2026 10:13

Copilot AI review requested due to automatic review settings February 17, 2026 10:13

Copilot started reviewing on behalf of udulaThathsaridu February 17, 2026 10:13 View session

Copilot AI reviewed Feb 17, 2026

View reviewed changes

ThinuwanW requested changes Feb 18, 2026

View reviewed changes

frontend/middleware.ts Show resolved Hide resolved

udulaThathsaridu added 2 commits February 18, 2026 19:48

fix/comments

cf2aa89

remove-APICTA-fallback

1160657

ThinuwanW changed the base branch from main to develop February 19, 2026 05:02

ThinuwanW requested changes Feb 19, 2026

View reviewed changes

	export const tempShouldUseCustomDashboard = () => {
	export const tempShouldUseCustomDashboard = (tenantId?: string \| number): boolean => {

		@@ -12,6 +15,8 @@ export const organizationCreateEndpoints = {
		export const authenticationEndpoints = {
		CREATE_SUPER_ADMIN: `${moduleAPIPath.AUTH}/signup/super-admin`,

		@@ -0,0 +1,29 @@
		import { SignInStatus } from "~community/auth/enums/auth";

Comments

Conversation

udulaThathsaridu commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist

TaskId: (https://rootcode.skapp.com/pm/projects/SKAPP/items/1381)

Summary

How to test

Project Checklist

Other

PR Checklist

Additional Information

Uh oh!

CLAassistant commented Feb 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Feb 19, 2026

Quality Gate passed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

udulaThathsaridu commented Feb 17, 2026 •

edited

Loading