Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a guest user flow issue by adding a new repository method to query employees including guest employees. Guest employees (those with the PM_GUEST_EMPLOYEE role) are typically filtered out in most employee queries, but this new method allows them to be included when needed, such as for resource availability calendars.
Changes:
- Added
findEmployeesIncludingGuestsmethod to EmployeeRepository interface - Implemented the method in EmployeeRepositoryImpl to search employees without filtering out guest users
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| backend/src/main/java/com/skapp/community/peopleplanner/repository/EmployeeRepository.java | Added interface method declaration for findEmployeesIncludingGuests with the same signature as the existing findEmployees method |
| backend/src/main/java/com/skapp/community/peopleplanner/repository/impl/EmployeeRepositoryImpl.java | Implemented findEmployeesIncludingGuests method similar to findEmployees but without the PM_GUEST_EMPLOYEE role exclusion filter and without joining the EmployeeRole table |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -234,6 +234,47 @@ else if (employeeIds != null && !employeeIds.isEmpty()) { | |||
| return query.getResultList(); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
The method findEmployeesIncludingGuests is missing the @Override annotation. All other methods in this implementation class that implement interface methods have the @Override annotation (see line 193 for the similar findEmployees method). This annotation should be added for consistency and to ensure compile-time verification that this method correctly overrides the interface method.
| @Override |
|
2 participants
PR checklist
TaskId: (https://github.com/SkappHQ/skapp/issues/[id])
Summary
How to test
Project Checklist
npm run formatnpm run check-lintOther
PR Checklist
ready-for-code-review)Additional Information